-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rust lib to set target vendor #275
Conversation
@jordanisaacs it is done with Niv, or you can just manually modify the file. |
0a664cd
to
d14ccb7
Compare
I couldn't run the tests locally because I got this error
|
I suspect #272 is not quite right. Try reverting that. |
@Ericson2314 I tried reverting it but did not change the error. Not entirely sure what is causing the error but it occurs when entering the |
@jordanisaacs Can you do it again with |
Ah, I can reproduce. |
Here is the super long trace if you still want it: https://gist.github.com/jordanisaacs/18fa608cb59dd924ec8567077ee01ff8 |
Occurs in building cargo-release |
Ah I was surprised because this looked like a bug I had fix. But it was! See #277 which bumps the prior version of crate2nix pinned in crate2nix. |
d14ccb7
to
1462c6d
Compare
@Ericson2314 Should be working now! ran |
Thanks :) |
Uses the new rust lib function
toTargetVendor
for setting the vendor for feature/dependency resolution & regeneratedCargo.nix
files. Needs nixpkgs to be updated to a version of 21.11 that includestoTargetVendor
, unsure how to do that.