Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust lib to set target vendor #275

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jordanisaacs
Copy link
Contributor

@jordanisaacs jordanisaacs commented Feb 16, 2023

Uses the new rust lib function toTargetVendor for setting the vendor for feature/dependency resolution & regenerated Cargo.nix files. Needs nixpkgs to be updated to a version of 21.11 that includes toTargetVendor, unsure how to do that.

@Ericson2314
Copy link
Collaborator

@jordanisaacs it is done with Niv, or you can just manually modify the file.

@jordanisaacs
Copy link
Contributor Author

I couldn't run the tests locally because I got this error

error: the string '2mz4bcqmqrkndkyqnbr57djd9fs6zqsh-crates-io-aho-corasick-0.7.18' is not allowed to refer to a store path (such as '!out!/nix/store/lpa1wknhyyin0hxd9scck1si0459hfpb-crates-io-aho-corasick-0.7.18.drv')

@Ericson2314
Copy link
Collaborator

I suspect #272 is not quite right. Try reverting that.

@jordanisaacs
Copy link
Contributor Author

@Ericson2314 I tried reverting it but did not change the error. Not entirely sure what is causing the error but it occurs when entering the nix-shell --pure shell.nix. I was runnning nix-shell on version 2.13.2

@Ericson2314
Copy link
Collaborator

@jordanisaacs Can you do it again with --show-trace?

@Ericson2314
Copy link
Collaborator

Ah, I can reproduce.

@jordanisaacs
Copy link
Contributor Author

Here is the super long trace if you still want it: https://gist.github.com/jordanisaacs/18fa608cb59dd924ec8567077ee01ff8

@jordanisaacs
Copy link
Contributor Author

Occurs in building cargo-release

@Ericson2314
Copy link
Collaborator

Ah I was surprised because this looked like a bug I had fix. But it was! See #277 which bumps the prior version of crate2nix pinned in crate2nix.

@jordanisaacs
Copy link
Contributor Author

@Ericson2314 Should be working now! ran ./run_tests.sh and they all passed.

@kolloch kolloch merged commit 1462c6d into nix-community:master Oct 25, 2023
@kolloch
Copy link
Collaborator

kolloch commented Oct 25, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants