From d0836eee0e2133af735cbaee0ce8968dad681b34 Mon Sep 17 00:00:00 2001 From: ronahk Date: Sun, 18 Dec 2022 14:25:43 +0200 Subject: [PATCH 1/7] update plugin version --- plugin.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin.yaml b/plugin.yaml index d2891509..31679672 100644 --- a/plugin.yaml +++ b/plugin.yaml @@ -1,5 +1,5 @@ name: "dashboard" -version: "0.2.8" +version: "0.3.0" usage: "A simplified way of working with Helm" description: "View HELM situation in nice web UI" command: "$HELM_PLUGIN_DIR/bin/helm-dashboard" From bae665026351f31f5b1079f4eee4e01a13a37d18 Mon Sep 17 00:00:00 2001 From: ronahk Date: Sun, 18 Dec 2022 14:27:12 +0200 Subject: [PATCH 2/7] fix pipeline --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index b28d9e92..c642ae1d 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -91,7 +91,7 @@ jobs: publish_chart: runs-on: ubuntu-latest - need: image + needs: image if: github.event_name == 'push' || github.event_name == 'workflow_dispatch' steps: - name: Checkout From c6b1586e88f98b2bd23c0f3eedc8b8477c0b03aa Mon Sep 17 00:00:00 2001 From: ronahk Date: Sun, 18 Dec 2022 14:40:09 +0200 Subject: [PATCH 3/7] fix pipeline --- .github/workflows/release.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index c642ae1d..3b474080 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -85,7 +85,7 @@ jobs: with: context: . push: ${{ github.event_name != 'pull_request' }} - tags: ${{ needs.pre_release.outputs.release_tag }} + tags: komodorio/helm-dashboard:${{ needs.pre_release.outputs.release_tag }},komodorio/helm-dashboard:latest labels: ${{ steps.meta.outputs.labels }} build-args: VER=${{ needs.pre_release.outputs.release_tag }} From cb535b1308903b3e278b132ce61c5fb4c8e66549 Mon Sep 17 00:00:00 2001 From: ronahk Date: Sun, 18 Dec 2022 15:00:52 +0200 Subject: [PATCH 4/7] add needs --- .github/workflows/release.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 3b474080..811e6c5d 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -60,7 +60,7 @@ jobs: image: runs-on: ubuntu-latest - needs: release + needs: [release, pre_release] timeout-minutes: 60 steps: - name: Check out the repo @@ -91,7 +91,7 @@ jobs: publish_chart: runs-on: ubuntu-latest - needs: image + needs: [image, pre_release] if: github.event_name == 'push' || github.event_name == 'workflow_dispatch' steps: - name: Checkout From d04eb97d3d61ae987eba8139ba6c8ac9d9777d0b Mon Sep 17 00:00:00 2001 From: ronahk Date: Mon, 19 Dec 2022 12:11:24 +0200 Subject: [PATCH 5/7] update chart icon --- charts/helm-dashboard/Chart.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/helm-dashboard/Chart.yaml b/charts/helm-dashboard/Chart.yaml index 14ff714b..3be4a909 100644 --- a/charts/helm-dashboard/Chart.yaml +++ b/charts/helm-dashboard/Chart.yaml @@ -3,7 +3,7 @@ type: application name: helm-dashboard description: A GUI Dashboard for Helm by Komodor -icon: "https://github.com/komodorio/helm-dashboard/blob/main/pkg/dashboard/static/logo.png" +icon: "https://raw.githubusercontent.com/komodorio/helm-dashboard/main/pkg/dashboard/static/logo.svg" version: 0.1.1 -appVersion: "0.3.0" +appVersion: "0.3.0" From e1df60ad69bb4670327e0a4e9c5df779a238933c Mon Sep 17 00:00:00 2001 From: ronahk Date: Mon, 19 Dec 2022 12:23:05 +0200 Subject: [PATCH 6/7] allow all api groups --- charts/helm-dashboard/templates/serviceaccount.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/helm-dashboard/templates/serviceaccount.yaml b/charts/helm-dashboard/templates/serviceaccount.yaml index 35cd4c6c..b93502ad 100644 --- a/charts/helm-dashboard/templates/serviceaccount.yaml +++ b/charts/helm-dashboard/templates/serviceaccount.yaml @@ -17,11 +17,11 @@ apiVersion: rbac.authorization.k8s.io/v1 metadata: name: {{ include "helm-dashboard.serviceAccountName" . }} rules: - - apiGroups: ["", "apps", "rbac.authorization.k8s.io", "rbac", "batch", "extensions", "networking.k8s.io", "storage.k8s.io"] + - apiGroups: ["*"] resources: ["*"] verbs: ["get", "list", "watch"] {{- if .Values.dashboard.allowWriteActions }} - - apiGroups: ["", "apps", "rbac.authorization.k8s.io", "rbac", "batch", "extensions", "networking.k8s.io", "storage.k8s.io"] + - apiGroups: ["*"] resources: ["*"] verbs: ["get", "list", "watch", "create", "delete", "patch", "update"] {{- end }} From 541947e8761890db748f4674db3f1e8a45fbde5c Mon Sep 17 00:00:00 2001 From: ronahk Date: Mon, 19 Dec 2022 12:26:41 +0200 Subject: [PATCH 7/7] allow write actions by default --- charts/helm-dashboard/README.md | 2 +- charts/helm-dashboard/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/helm-dashboard/README.md b/charts/helm-dashboard/README.md index 3d64d450..3b8c2389 100644 --- a/charts/helm-dashboard/README.md +++ b/charts/helm-dashboard/README.md @@ -49,7 +49,7 @@ The following table lists the configurable parameters of the chart and their def | `image.tag` | Image tag | | | `image.pullPolicy` | Image pull policy | `IfNotPresent` | | `replicaCount` | Number of dashboard Pods to run | `1` | -| `dashboard.allowWriteActions` | Enables write actions. Allow modifying, deleting and creating charts and kubernetes resources. | `false` | +| `dashboard.allowWriteActions` | Enables write actions. Allow modifying, deleting and creating charts and kubernetes resources. | `true` | | `resources.requests.cpu` | CPU resource requests | `200m` | | `resources.limits.cpu` | CPU resource limits | `1` | | `resources.requests.memory` | Memory resource requests | `256Mi` | diff --git a/charts/helm-dashboard/values.yaml b/charts/helm-dashboard/values.yaml index df768b38..168fc766 100644 --- a/charts/helm-dashboard/values.yaml +++ b/charts/helm-dashboard/values.yaml @@ -26,7 +26,7 @@ resources: memory: 1Gi dashboard: - allowWriteActions: false + allowWriteActions: true persistence: enabled: true