Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Past commit change altered code inconsistently #537

Closed
KoenDG opened this issue Feb 13, 2024 · 3 comments · Fixed by #538
Closed

Past commit change altered code inconsistently #537

KoenDG opened this issue Feb 13, 2024 · 3 comments · Fixed by #538
Assignees

Comments

@KoenDG
Copy link
Contributor

KoenDG commented Feb 13, 2024

Looking at the commits of the last few weeks and I run into this: ded0701#diff-e859dde9a1e131eb9dd0766f31c9a43e88a3818ca8b4f882faf98a8729b5d9d7

In tasks/aide.yml.

The old code looks like this, on line 165:

when: ansible_os_family == "RedHat" and not rhelaidedbnew.stat.exists

And the new code like this:

  when:
    - ansible_os_family == "RedHat"
    - rhelaidedbnew.stat.exists

That's not the same code. The not was removed. What used to be A && !B is now A && B. And there's a few more like that.

Is this intended?

@konstruktoid
Copy link
Owner

Nope, that's a bug, accidentally wiped that not.

@KoenDG
Copy link
Contributor Author

KoenDG commented Feb 13, 2024

Far as I was able to tell, that commit and the aide role was the only affected.

Of course, that is a visual and manual verification

@konstruktoid
Copy link
Owner

Yeah, I'll go over it all again and fix the aide task.

Thanks for the report @KoenDG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants