Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition: null connection object #694

Closed
daniele-athome opened this issue Apr 25, 2016 · 0 comments
Closed

Race condition: null connection object #694

daniele-athome opened this issue Apr 25, 2016 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@daniele-athome
Copy link
Member

daniele-athome commented Apr 25, 2016

And again...

java.lang.NullPointerException
       at org.jivesoftware.smackx.csi.ClientStateIndicationManager.isSupported(ClientStateIndicationManager.java:41)
       at org.jivesoftware.smackx.csi.ClientStateIndicationManager.throwIaeIfNotSupported(ClientStateIndicationManager.java:45)
       at org.jivesoftware.smackx.csi.ClientStateIndicationManager.inactive(ClientStateIndicationManager.java:36)
       at org.kontalk.service.msgcenter.MessageCenterService.inactive(MessageCenterService.java:1400)
       at org.kontalk.service.msgcenter.MessageCenterService.access$200(MessageCenterService.java:148)
       at org.kontalk.service.msgcenter.MessageCenterService$IdleConnectionHandler.handleMessage(MessageCenterService.java:440)
       at org.kontalk.service.msgcenter.MessageCenterService$IdleConnectionHandler.handleMessage(MessageCenterService.java:420)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:176)
       at android.os.HandlerThread.run(HandlerThread.java:60)

It seems that just checking against null isn't enough (damn concurrency).

@daniele-athome daniele-athome added the bug Something isn't working label Apr 25, 2016
@daniele-athome daniele-athome modified the milestones: 4.0, 3.1.9 Apr 25, 2016
@daniele-athome daniele-athome self-assigned this Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant