Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Accept header field value in DeliveryClient.buildNewRequest() #154

Closed
Dakkaron opened this issue Nov 28, 2024 · 3 comments
Closed

Comments

@Dakkaron
Copy link

Brief bug description

Requests are sent with header Accept set to applications/json instead of application/json.

Repro steps

  1. Send a request e.g. using DeliveryClient.getItem().
  2. Observe the headers of the sent request.
  3. It is applications/json.

Expected behavior

Accept header should be set to application/json.

Test environment

  • Platform/OS: Java, Windows
  • Browser: N/A
  • Version: Current master branch

Additional context

The problem derives from https://github.com/kontent-ai/java-packages/blob/master/delivery-sdk/src/main/java/kontent/ai/delivery/DeliveryClient.java, line 587.

@Dakkaron Dakkaron changed the title Wrong header field in DeliveryClient.buildNewRequest() Wrong Accept header field value in DeliveryClient.buildNewRequest() Nov 28, 2024
@IvanKiral
Copy link
Contributor

Hey, I created a PR #155 can you check it out?

@Dakkaron
Copy link
Author

Dakkaron commented Jan 8, 2025

Nice, thanks a lot, looks great!

@IvanKiral
Copy link
Contributor

Should be released in 5.1.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants