From 2f8bd4223135a9b0ecdbc5eb5d9e59ceca2ffa1d Mon Sep 17 00:00:00 2001 From: Shveta Sachdeva Date: Tue, 28 Jan 2025 15:59:25 -0800 Subject: [PATCH] Launch vscode Signed-off-by: Shveta Sachdeva --- .github/workflows/windows-nightly-ci.yml | 32 ++++++++++++------------ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/windows-nightly-ci.yml b/.github/workflows/windows-nightly-ci.yml index a5427d2a..a67cfb0b 100644 --- a/.github/workflows/windows-nightly-ci.yml +++ b/.github/workflows/windows-nightly-ci.yml @@ -2,23 +2,23 @@ name: (Windows)(nonadmin) Run Playwright tests nightly on main branch on: push jobs: - # start-ec2-instance: - # uses: ./.github/workflows/provision-runner.yml - # with: - # ec2-image-id: ami-0cf05b9bbda99aed3 - # ec2-instance-type: t2.micro - # security-group-id: sg-0a3e6b53e86d0e69d - # subnet-id: subnet-06113672589e7e836 - # ec2-os-type: windows - # secrets: - # aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} - # aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - # github-token: ${{ secrets.GH_RUNNER_API_TOKEN }} - # nonadmin-password: ${{ secrets.NONADMIN_PASSWORD }} + start-ec2-instance: + uses: ./.github/workflows/provision-runner.yml + with: + ec2-image-id: ami-0cf05b9bbda99aed3 + ec2-instance-type: t2.micro + security-group-id: sg-0a3e6b53e86d0e69d + subnet-id: subnet-06113672589e7e836 + ec2-os-type: windows + secrets: + aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} + github-token: ${{ secrets.GH_RUNNER_API_TOKEN }} + nonadmin-password: ${{ secrets.NONADMIN_PASSWORD }} install-requirements-as-admin: - # needs: start-ec2-instance - runs-on: l4q7l + needs: start-ec2-instance + runs-on: ${{ needs.start-ec2-instance.outputs.instance_label }} steps: - name: Install Node.js run: choco install nodejs -y @@ -43,7 +43,7 @@ jobs: Get-Process -Name "Code" -ErrorAction SilentlyContinue | ForEach-Object { $_.CloseMainWindow() } | Out-Null run-test-as-nonadmin: - needs: [ install-requirements-as-admin] + needs: [ start-ec2-instance, install-requirements-as-admin] runs-on: ubuntu-latest steps: