✨ Add app details: Include a list of targets the project was checked against #2140
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainst Signed-off-by: DvoraShechter1 <[email protected]>
DvoraShechter1
requested review from
ibolton336,
sjd78 and
rszwajko
as code owners
…ainst Signed-off-by: DvoraShechter1 <[email protected]>
Signed-off-by: sarinailinger <[email protected]>
Signed-off-by: DvoraShechter1 <[email protected]>
Translation support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 39.20% 41.97% +2.77%
==========================================
Files 146 175 +29
Lines 4857 5644 +787
Branches 1164 1343 +179
==========================================
+ Hits 1904 2369 +465
- Misses 2939 3259 +320
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
requested changes
Oct 30, 2024
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
...rc/app/pages/applications/components/application-detail-drawer/application-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
…attribute to mapped components and 'Not available' message for empty analysis. Signed-off-by: DvoraShechter1 <[email protected]>
sjd78
requested changes
Feb 5, 2025
| @@ -303,6 +308,18 @@ const TabDetailsContent: React.FC<{ | |||
| onEditClick={onEditClick} | |||
| onCloseClick={onCloseClick} | |||
| /> | |||
| <TextContent className={spacing.mtLg}> | |||
There was a problem hiding this comment.
Since this is talking about the targets for an analysis, this content should be on the Reports tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iInformation in the app details:
list of targets that the project was checked against
part 1 from #2012