Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an abstract class AbstractMavenAccessor? #66

Open
sdruskat opened this issue Nov 18, 2015 · 0 comments
Open

Create an abstract class AbstractMavenAccessor? #66

sdruskat opened this issue Nov 18, 2015 · 0 comments
Assignees
@MartinKl
Labels
enhancement

Comments

@sdruskat
Copy link
Contributor

The constructor of MavenAccessor takes as argument an object of class PepperOSGiConnector.

This makes it hard to inherit from MavenAccessor in contexts where other than the default PepperConnector is used. I.e., when inheriting from MavenAccessor you'd still have to call super({Object of class extending PepperConnector}), which can result in an NPE at MavenAccessor, line 207.

One solution could be to create an abstract class AbstractMavenAccessor, which takes PepperConnector as an argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinKl MartinKl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinKl @sdruskat