Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colon in filename causes attestation signing to fail #94

Closed
kpcyrd opened this issue Nov 25, 2021 · 0 comments · Fixed by #96
Closed

Colon in filename causes attestation signing to fail #94

kpcyrd opened this issue Nov 25, 2021 · 0 comments · Fixed by #96

Comments

@kpcyrd
Copy link
Owner

kpcyrd commented Nov 25, 2021

@foutrelis discovered reproducible packages with a colon : in their filename are flagged as BAD because the attestation can't be generated:

[2021-11-25T00:30:18Z INFO  rebuilderd_worker::rebuild] Comparing "/tmp/rebuilderd7RU43S/inputs/re2-1:20211101-1-x86_64.pkg.tar.zst" with "/tmp/rebuilderd7RU43S/out/re2-1:20211101-1-x86_64.pkg.tar.zst"
[2021-11-25T00:30:18Z INFO  rebuilderd_worker::rebuild] Files are identical, marking as GOOD
[2021-11-25T00:30:18Z INFO  rebuilderd_worker::rebuild] Generating signed link
[2021-11-25T00:30:18Z ERROR rebuilderd_worker] Unexpected error while rebuilding package package: Failed to generate in-toto attestation: illegal argument: Path cannot contain ":"
[2021-11-25T00:30:18Z INFO  rebuilderd_worker] Sending build report to rebuilderd...

This causes rebuilderd to return an Result::Err for the rebuild which is reported to the rebuilderd daemon as a failed rebuild (the log is set to an empty string in this case). This seems to affect all Arch Linux package with an epoch= set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant