Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all signature verification algorithms #2

Closed
2 tasks done
kpp opened this issue Jul 13, 2021 · 2 comments · Fixed by #4
Closed
2 tasks done

Support all signature verification algorithms #2

kpp opened this issue Jul 13, 2021 · 2 comments · Fixed by #4

Comments

@kpp
Copy link
Owner

kpp commented Jul 13, 2021 •
edited
Loading

rust-libp2p/transports/tls-quic/src/certificate.rs

Line 211 in b8d277d

// FIXME: not all algorithms are supported.

rust-libp2p/transports/tls-quic/src/certificate.rs

Line 222 in b8d277d

// FIXME: update https://github.com/rusticata/oid-registry/ and use oids from it

  • SHA1 should not be supported
  • ed25519 should be supported

These are FIXMEs left in #1.
@kpp kpp mentioned this issue Jul 13, 2021
Closed
4 tasks
@kpp
Copy link
Owner Author

kpp commented Jul 13, 2021

See https://tools.ietf.org/id/draft-ietf-tls-tls13-21.html#rfc.section.4.2.3 for a full list of signature algos.

@kpp
Copy link
Owner Author

kpp commented Jul 14, 2021

Depends on rusticata/oid-registry#6

@kpp kpp mentioned this issue Jul 14, 2021
Merged
@kpp kpp closed this as completed in #4 Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support all verification algorithms kpp/rust-libp2p
1 participant
@kpp