Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify interfaces of base classes with the descendants #230

Closed
Calychas opened this issue Apr 24, 2023 · 0 comments · Fixed by #235
Closed

Unify interfaces of base classes with the descendants #230

Calychas opened this issue Apr 24, 2023 · 0 comments · Fixed by #235
Assignees
@piotrgramacki
Labels
bug Something isn't working
Milestone
Release first wor...

Comments

@Calychas
Copy link
Collaborator

Calychas commented Apr 24, 2023 •
edited
Loading

Currently, base classes of e.g. Loaders or Regionizers exist, but are not used across the specific implementations. This needs to be unified
@Calychas Calychas added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 24, 2023
@piotrgramacki piotrgramacki self-assigned this Apr 24, 2023
@piotrgramacki piotrgramacki mentioned this issue Apr 24, 2023
Merged
@piotrgramacki piotrgramacki linked a pull request Apr 24, 2023 that will close this issue
fix: use common interface in joiners and loaders #235
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotrgramacki piotrgramacki

Labels
bug Something isn't working
Projects
None yet
Milestone
Release first working version
Development

Successfully merging a pull request may close this issue.

fix: use common interface in joiners and loaders kraina-ai/srai
2 participants
@Calychas @piotrgramacki