Partial scss files automatically compiled

[alex88]

I'm not sure if it's a bug or a non-correct use of the library, I've create a sample app to demonstrate the issue: https://github.com/alex88/assetic-test

I've configured assetic this way so I don't have to add the filter in all the stylesheets declarations:

assetic:
    debug:            "%kernel.debug%"
    use_controller:   "%kernel.debug%"
    filters:
        scssphp:
            apply_to:  "\\.scss$"
            formatter: 'Leafo\ScssPhp\Formatter\Compressed'

and I've this sample structure (bootstrap source has something like that) https://github.com/alex88/assetic-test/tree/master/web/assets/scss

Basically there is bootstrap.scss which is the main file and it's what is included in the template, then there is a _mixins.scss partial that includes the mixins and a _something.scss partial which includes a scss rule using the mixin provided by the previous partial.

Now, assetic:dump works fine since includes the files in the various stylesheets declarations in the templates, and so includes the partials in the correct order and dependency.

assetic:watch instead since tries to compile all files gives error on the _something.scss partial since doesn't include the mixins partial.

Is that an expected behaviour since that's what the apply_to setting actually does or is it a bug?

[alex88]

I've tried to manually exclude files starting with an underscore changing the apply_to to ^[^_]*\.scss$, however it still tries to compile the partials due the function in ScssphpFilter:

ctImports($content) as $match) {
    $file = $sc->findImport($match);
    if ($file) {
        $children[] = $child = $factory->createAsset($file, array(), array('root' => $loadPath));
        $child->load();
        $children = array_merge($children, $this->getChildren($factory, $child->getContent(), $loadPath));
    }
}

which seems to automatically create an asset for the dependant files, maybe worth checking if those files are in the apply_to filter?

[alex88]

So the automatic load of the child asset makes the compiler automatically run on it.
I've tried to exclude the child by checking the underscore at the beginning and it actually worked without any error (ofc this is the hardcoded solution in my case)

[Viburnum]

+1

[koddistortion]

+1

[Viburnum]

Added a flag to ignore partial files in the ScssphpFilter #830