Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

further dry-run improvements: txEvents & top #167

Open
marc0olo opened this issue Jul 5, 2021 · 4 comments
Open

further dry-run improvements: txEvents & top #167

marc0olo opened this issue Jul 5, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@marc0olo
Copy link
Member

marc0olo commented Jul 5, 2021

@mitch-lbw do we currently support that? if not we should introduce that functionality
@marc0olo marc0olo added the question Further information is requested label Jul 5, 2021
@mitch-lbw
Copy link
Member

mitch-lbw commented Aug 28, 2021 •
edited
Loading

Currently we don't have support for this - i would propose to introduce the specific height as param to AbstractTransactionModel rather than providing new methods or update existing signatures within TransactionServiceImpl - what do you think @marc0olo?

@marc0olo
Copy link
Member Author

you mean for the existing dryRun functions, right?

@marc0olo marc0olo added enhancement New feature or request and removed question Further information is requested labels Dec 18, 2021
@marc0olo marc0olo changed the title perform a dry-run for a transaction at a specific height further dry-run improvements: txEvents & top Dec 18, 2021
@marc0olo
Copy link
Member Author

marc0olo commented Dec 18, 2021 •
edited
Loading

it should be possible to perform a dry-run at a specific height. additionally there is an option to return the txEvents for tx performed in a dry-run which is set to false by default.

the height/top to perform the dry-run expects a block hash. currently I am not sure if it's on keyblock level or microblock level.

@marc0olo
Copy link
Member Author

I got the confirmation of Hans that it doesn't matter if we provide the microblock or keyblock hash. both can be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marc0olo @mitch-lbw