refactoring of the TransactionFactory and Services/ApiClients

[marc0olo]

• provide methods with predefined default values where it makes sense
  • devs shouldn't always need to provide all parameters
  • we have built a wrapper around the builder-methods but in fact we want to provide the builder for the developers
• check @NonNull attributes of all Transaction types (e.g. payload for SpendTransaction shouldn't be required)
• consider decode Tx-hashes into our TxModel classes #48 for the design after refactoring

[marc0olo]

I think we should mark the TransactionFactory deprecated and provide default values for the required fields and let the developers directly access the builder of each transaction type.

The open question then is how to perform the createInternal method for the debugApi which currently requires an initialized ApiClient for each transaction type.

• we should return a builder where feeCalculationModel the required ApiClient is already initialized

[marc0olo]

@mitch-lbw we should also think about a way to get access to all ApiClients with a certain configuration as this shouldn't be provided by the TransactionService.

currently we e.g. define a ChainService and an AccountService just to get access to the methods provided by the ApiClients

edit:

• after a small discussion we decided to keep a facade to access all endpoints

[mitch-lbw]

Yes - as discussed - we would not recommend to expose generated ApiClients because the underlying AE protocol is currently not stable atm. Furthermore we want provide an SDK which aims to realize a reliable API.

[marc0olo]

please consider #48 for the design after refactoring:

• 4c28dd0

maybe this can also be made more generic. a look into the python sdk might help:

• https://github.com/aeternity/aepp-sdk-python/blob/develop/aeternity/transactions.py

[marc0olo]

#48 won't be included in this refactoring.