-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added refreshing OIDC ID token as an optional feature #1229
Conversation
Signed-off-by: Razz4780 <[email protected]>
eb8e8c3
to
74ba0ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much for doing this, this looks great.
have left only some minor comments on it so far, but layout wise it looks very much like what we need for this.
for the million dollar question; does it work? :D
i don't know exactly what we can do to test this (we are not really testing the other oauth flow either), if you have any ideas for it it would be welcome.
I'm trying to setup some auth flow to test this manually, but I'm failing :V |
this is a hard one to test. i am okay with getting this released and getting user feedback for now. it does match the state of how things are in oauth (even though of course having tests for it would be better). |
Signed-off-by: Razz4780 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
- Coverage 73.04% 72.08% -0.97%
==========================================
Files 69 71 +2
Lines 5525 5714 +189
==========================================
+ Hits 4036 4119 +83
- Misses 1489 1595 +106
|
NB: Ignore the cargo deny bans issues. Not your fault and this occasionally happens sans-lockfiles. Will be addressed separately. |
Signed-off-by: Razz4780 <[email protected]>
Signed-off-by: Razz4780 <[email protected]>
dfc2e28
to
b14b70f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are looking great. just found one minor nit when verifying the documentation for it looked OK. have added a small diff.
Signed-off-by: Razz4780 <[email protected]>
Solves #1223
Motivation
When OIDC is configured as the authentication method in the kubeconfig, the ID token is never refreshed. This feature is implemented in other tools, e.g.
kubectl
.Solution
Added a new feature
oidc
. When this feature is enabled and the auth provider config contains enough info to enable refreshing, the ID token is refreshed when it's near or past its expiration date.Implementation requires extra optional dependency on
form_urlencoded
.