-
Notifications
You must be signed in to change notification settings - Fork 458
/
Copy pathvalidator_test.go
1499 lines (1416 loc) · 46.9 KB
/
validator_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2022 The Kubeflow Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package validator
import (
"errors"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
experimentutil "github.com/kubeflow/katib/pkg/controller.v1beta1/experiment/util"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/apimachinery/pkg/util/validation/field"
"go.uber.org/mock/gomock"
batchv1 "k8s.io/api/batch/v1"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
configv1beta1 "github.com/kubeflow/katib/pkg/apis/config/v1beta1"
commonv1beta1 "github.com/kubeflow/katib/pkg/apis/controller/common/v1beta1"
experimentsv1beta1 "github.com/kubeflow/katib/pkg/apis/controller/experiments/v1beta1"
"github.com/kubeflow/katib/pkg/controller.v1beta1/util"
manifestmock "github.com/kubeflow/katib/pkg/mock/v1beta1/experiment/manifest"
)
func init() {
logf.SetLogger(zap.New())
}
func TestValidateExperiment(t *testing.T) {
mockCtrl := gomock.NewController(t)
defer mockCtrl.Finish()
p := manifestmock.NewMockGenerator(mockCtrl)
g := New(p)
suggestionConfigData := configv1beta1.SuggestionConfig{}
suggestionConfigData.Image = "algorithmImage"
metricsCollectorConfigData := configv1beta1.MetricsCollectorConfig{}
metricsCollectorConfigData.Image = "metricsCollectorImage"
earlyStoppingConfigData := configv1beta1.EarlyStoppingConfig{}
p.EXPECT().GetSuggestionConfigData(gomock.Any()).Return(suggestionConfigData, nil).AnyTimes()
p.EXPECT().GetMetricsCollectorConfigData(gomock.Any()).Return(metricsCollectorConfigData, nil).AnyTimes()
p.EXPECT().GetEarlyStoppingConfigData(gomock.Any()).Return(earlyStoppingConfigData, nil).AnyTimes()
batchJobStr := convertBatchJobToString(newFakeBatchJob())
p.EXPECT().GetTrialTemplate(gomock.Any()).Return(batchJobStr, nil).AnyTimes()
fakeNegativeInt := int32(-1)
tcs := []struct {
instance *experimentsv1beta1.Experiment
wantErr field.ErrorList
oldInstance *experimentsv1beta1.Experiment
testDescription string
}{
// Name
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Name = "1234-test"
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("metadata").Child("name"), "", ""),
},
testDescription: "Name is invalid",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Name = "test-manymanymanyextracharactersthatgobeyondlimit"
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("metadata").Child("name"), "", ""),
},
testDescription: "Name is invalid",
},
// Objective
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Objective = nil
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("objective"), ""),
},
testDescription: "Objective is nil",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Objective.Type = commonv1beta1.ObjectiveTypeUnknown
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("objective").Child("type"), "", ""),
},
testDescription: "Objective type is unknown",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Objective.ObjectiveMetricName = ""
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("objective").Child("objectiveMetricName"), ""),
},
testDescription: "Objective metric name is empty",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Objective.ObjectiveMetricName = "objective"
i.Spec.Objective.AdditionalMetricNames = []string{"objective", "objective-1"}
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("objective").Child("additionalMetricNames"), "", ""),
},
testDescription: "additionalMetricNames should not contain objective metric name",
},
// Algorithm
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Algorithm = nil
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("algorithm"), ""),
},
testDescription: "Algorithm is nil",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Algorithm.AlgorithmName = ""
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("algorithm").Child("algorithmName"), ""),
},
testDescription: "Algorithm name is empty",
},
// EarlyStopping
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.EarlyStopping = nil
return i
}(),
testDescription: "EarlyStopping is nil",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.EarlyStopping.AlgorithmName = ""
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("earlyStopping").Child("algorithmName"), ""),
},
testDescription: "EarlyStopping AlgorithmName is empty",
},
// Valid Experiment
{
instance: newFakeInstance(),
testDescription: "Run validator for correct experiment",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.MaxFailedTrialCount = &fakeNegativeInt
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("maxFailedTrialCount"), "", ""),
},
testDescription: "Max failed trial count is negative",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.MaxTrialCount = &fakeNegativeInt
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("maxTrialCount"), "", ""),
},
testDescription: "Max trial count is negative",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.ParallelTrialCount = &fakeNegativeInt
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("parallelTrialCount"), "", ""),
},
testDescription: "Parallel trial count is negative",
},
// Validate Resume Experiment
{
instance: newFakeInstance(),
oldInstance: newFakeInstance(),
testDescription: "Run validator to correct resume experiment",
},
{
instance: newFakeInstance(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("resumePolicy"), "", ""),
field.Forbidden(field.NewPath("spec"), ""),
},
oldInstance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.MarkExperimentStatusSucceeded(experimentutil.ExperimentMaxTrialsReachedReason, "Experiment is succeeded")
i.Spec.ResumePolicy = experimentsv1beta1.NeverResume
return i
}(),
testDescription: "Resume succeeded experiment with ResumePolicy = NeverResume",
},
{
instance: newFakeInstance(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("maxTrialCount"), "", ""),
},
oldInstance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Status = experimentsv1beta1.ExperimentStatus{
Trials: *i.Spec.MaxTrialCount,
}
var failed int32 = 2
i.Spec.MaxFailedTrialCount = &failed
return i
}(),
testDescription: "Resume experiment with MaxTrialCount <= Status.Trials",
},
{
instance: newFakeInstance(),
wantErr: field.ErrorList{
field.Forbidden(field.NewPath("spec"), ""),
},
oldInstance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Algorithm.AlgorithmName = "not-test"
return i
}(),
testDescription: "Change algorithm name when resuming experiment",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.ResumePolicy = "invalid-policy"
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("resumePolicy"), "", ""),
},
testDescription: "Invalid resume policy",
},
// Validate NAS Config
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Parameters = []experimentsv1beta1.ParameterSpec{}
i.Spec.NasConfig = nil
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec"), ""),
},
testDescription: "Parameters and NAS config is nil",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.NasConfig = &experimentsv1beta1.NasConfig{
Operations: []experimentsv1beta1.Operation{
{
OperationType: "op1",
},
},
}
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec"), "", ""),
},
testDescription: "Parameters and NAS config is not nil",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate = nil
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate"), ""),
},
testDescription: "Trial template is nil",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Parameters[1].FeasibleSpace.Max = "5"
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("parameters").Index(1).Child("feasibleSpace"), "", ""),
},
testDescription: "Invalid feasible space in parameters",
},
{
instance: func() *experimentsv1beta1.Experiment {
maxTrialCount := int32(5)
invalidMaxFailedTrialCount := int32(6)
i := newFakeInstance()
i.Spec.MaxTrialCount = &maxTrialCount
i.Spec.MaxFailedTrialCount = &invalidMaxFailedTrialCount
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("maxFailedTrialCount"), "", ""),
},
testDescription: "maxFailedTrialCount greater than maxTrialCount",
},
{
instance: func() *experimentsv1beta1.Experiment {
maxTrialCount := int32(5)
validMaxFailedTrialCount := int32(5)
i := newFakeInstance()
i.Spec.MaxTrialCount = &maxTrialCount
i.Spec.MaxFailedTrialCount = &validMaxFailedTrialCount
return i
}(),
testDescription: "maxFailedTrialCount equal to maxTrialCount",
},
{
instance: func() *experimentsv1beta1.Experiment {
maxTrialCount := int32(5)
invalidParallelTrialCount := int32(6)
i := newFakeInstance()
i.Spec.MaxTrialCount = &maxTrialCount
i.Spec.ParallelTrialCount = &invalidParallelTrialCount
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("parallelTrialCount"), "", ""),
},
testDescription: "parallelTrialCount greater than maxTrialCount",
},
{
instance: func() *experimentsv1beta1.Experiment {
maxTrialCount := int32(5)
validParallelTrialCount := int32(5)
i := newFakeInstance()
i.Spec.MaxTrialCount = &maxTrialCount
i.Spec.ParallelTrialCount = &validParallelTrialCount
return i
}(),
testDescription: "parallelTrialCount equal to maxTrialCount",
},
}
for _, tc := range tcs {
gotError := g.ValidateExperiment(tc.instance, tc.oldInstance)
if diff := cmp.Diff(tc.wantErr, gotError, cmpopts.IgnoreFields(field.Error{}, "Detail", "BadValue")); len(diff) != 0 {
t.Errorf("Unexpected errors (-want,+got):\n%s", diff)
}
}
}
func TestValidateParameters(t *testing.T) {
mockCtrl := gomock.NewController(t)
defer mockCtrl.Finish()
p := manifestmock.NewMockGenerator(mockCtrl)
g := New(p)
tcs := []struct {
parameters []experimentsv1beta1.ParameterSpec
wantErr field.ErrorList
testDescription string
}{
{
parameters: func() []experimentsv1beta1.ParameterSpec {
ps := newFakeInstance().Spec.Parameters
ps[0].ParameterType = "invalid-type"
return ps
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("parameters").Index(0).Child("parameterType"), "", ""),
},
testDescription: "Invalid parameter type",
},
{
parameters: func() []experimentsv1beta1.ParameterSpec {
ps := newFakeInstance().Spec.Parameters
ps[0].FeasibleSpace = experimentsv1beta1.FeasibleSpace{}
return ps
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("parameters").Index(0).Child("feasibleSpace"), ""),
},
testDescription: "Feasible space is nil",
},
{
parameters: func() []experimentsv1beta1.ParameterSpec {
ps := newFakeInstance().Spec.Parameters
ps[0].FeasibleSpace.List = []string{"invalid-list"}
return ps
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("parameters").Index(0).Child("feasibleSpace").Child("list"), "", ""),
},
testDescription: "Not empty list for int parameter type",
},
{
parameters: func() []experimentsv1beta1.ParameterSpec {
ps := newFakeInstance().Spec.Parameters
ps[0].FeasibleSpace = experimentsv1beta1.FeasibleSpace{
Max: "",
Min: "",
Step: "1",
}
return ps
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("parameters").Index(0).Child("feasibleSpace").Child("max"), ""),
},
testDescription: "Empty max and min for int parameter type",
},
{
parameters: func() []experimentsv1beta1.ParameterSpec {
ps := newFakeInstance().Spec.Parameters
ps[1].FeasibleSpace.Max = "1"
return ps
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("parameters").Index(1).Child("feasibleSpace"), "", ""),
},
testDescription: "Not empty max for categorical parameter type",
},
{
parameters: func() []experimentsv1beta1.ParameterSpec {
ps := newFakeInstance().Spec.Parameters
ps[0].FeasibleSpace.Distribution = "invalid-distribution"
return ps
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("parameters").Index(0).Child("feasibleSpace").Child("distribution"), "", ""),
},
testDescription: "Invalid distribution type",
},
{
parameters: newFakeInstance().Spec.Parameters,
wantErr: nil,
testDescription: "Valid parameters case",
},
}
for _, tc := range tcs {
gotError := g.(*DefaultValidator).validateParameters(tc.parameters)
if diff := cmp.Diff(tc.wantErr, gotError, cmpopts.IgnoreFields(field.Error{}, "Detail", "BadValue")); len(diff) != 0 {
t.Errorf("Unexpected errors (-want,+got):\n%s", diff)
}
}
}
func TestValidateTrialTemplate(t *testing.T) {
mockCtrl := gomock.NewController(t)
defer mockCtrl.Finish()
p := manifestmock.NewMockGenerator(mockCtrl)
g := New(p)
validJobStr := convertBatchJobToString(newFakeBatchJob())
missedParameterJob := newFakeBatchJob()
missedParameterJob.Spec.Template.Spec.Containers[0].Command[2] = "--lr=${trialParameters.invalidParameter}"
missedParameterJobStr := convertBatchJobToString(missedParameterJob)
oddParameterJob := newFakeBatchJob()
oddParameterJob.Spec.Template.Spec.Containers[0].Command = append(
oddParameterJob.Spec.Template.Spec.Containers[0].Command,
"--extra-parameter=${trialParameters.extraParameter}")
oddParameterJobStr := convertBatchJobToString(oddParameterJob)
invalidParameterJobStr := `apiVersion: batch/v1
kind: Job
spec:
template:
spec:
containers:
- name: fake-trial
image: test-image
command:
- --invalidParameter={'num_layers': 2, 'input_sizes': [32, 32, 3]}
- --lr=${trialParameters.learningRate}"
- --num-layers=${trialParameters.numberLayers}`
notEmptyMetadataJob := newFakeBatchJob()
notEmptyMetadataJob.ObjectMeta = metav1.ObjectMeta{
Name: "trial-name",
Namespace: "trial-namespace",
}
notEmptyMetadataStr := convertBatchJobToString(notEmptyMetadataJob)
emptyAPIVersionJob := newFakeBatchJob()
emptyAPIVersionJob.TypeMeta.APIVersion = ""
emptyAPIVersionStr := convertBatchJobToString(emptyAPIVersionJob)
customJobType := newFakeBatchJob()
customJobType.TypeMeta.Kind = "CustomKind"
customJobTypeStr := convertBatchJobToString(customJobType)
emptyConfigMap := p.EXPECT().GetTrialTemplate(gomock.Any()).Return("", errors.New(string(metav1.StatusReasonNotFound)))
validTemplate1 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate2 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate3 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate4 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate5 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate6 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate7 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate8 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate9 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate10 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
validTemplate11 := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(validJobStr, nil)
missedParameterTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(missedParameterJobStr, nil)
oddParameterTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(oddParameterJobStr, nil)
invalidParameterTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(invalidParameterJobStr, nil)
notEmptyMetadataTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(notEmptyMetadataStr, nil)
emptyAPIVersionTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(emptyAPIVersionStr, nil)
customJobTypeTemplate := p.EXPECT().GetTrialTemplate(gomock.Any()).Return(customJobTypeStr, nil)
gomock.InOrder(
emptyConfigMap,
validTemplate1,
validTemplate2,
validTemplate3,
validTemplate4,
validTemplate5,
validTemplate6,
validTemplate7,
validTemplate8,
validTemplate9,
missedParameterTemplate,
oddParameterTemplate,
invalidParameterTemplate,
notEmptyMetadataTemplate,
emptyAPIVersionTemplate,
customJobTypeTemplate,
validTemplate10,
validTemplate11,
)
tcs := []struct {
instance *experimentsv1beta1.Experiment
wantErr field.ErrorList
testDescription string
}{
// TrialParameters is nil
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters = nil
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate").Child("trialParameters"), ""),
},
testDescription: "Trial parameters is nil",
},
// TrialSpec and ConfigMap is nil
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialSpec = nil
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate").Child("TrialSource"), ""),
},
testDescription: "Trial spec nil",
},
// TrialSpec and ConfigMap is not nil
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialSource.ConfigMap = &experimentsv1beta1.ConfigMapSource{
ConfigMapName: "config-map-name",
ConfigMapNamespace: "config-map-namespace",
TemplatePath: "config-map-template-path",
}
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate"), ""),
},
testDescription: "Trial spec and ConfigMap is not nil",
},
// ConfigMap missed template path
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialSource = experimentsv1beta1.TrialSource{
ConfigMap: &experimentsv1beta1.ConfigMapSource{
ConfigMapName: "config-map-name",
ConfigMapNamespace: "config-map-namespace",
},
}
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate").Child("configMap"), ""),
},
testDescription: "Missed template path in ConfigMap",
},
// Wrong path in configMap
// emptyConfigMap case
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialSpec = nil
i.Spec.TrialTemplate.TrialSource = experimentsv1beta1.TrialSource{
ConfigMap: &experimentsv1beta1.ConfigMapSource{
ConfigMapName: "config-map-name",
ConfigMapNamespace: "config-map-namespace",
TemplatePath: "wrong-path",
},
}
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Wrong template path in ConfigMap",
},
// Empty Reference or Name in trialParameters
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[0].Reference = ""
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate").Child("trialParameters").Index(0), "", ""),
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Empty reference or name in Trial parameters",
},
// Wrong Name in trialParameters
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[0].Name = "{invalid-name}"
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate").Child("trialParameters").Index(0), "", ""),
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Wrong name in Trial parameters",
},
// Duplicate Name in trialParameters
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[1].Name = i.Spec.TrialTemplate.TrialParameters[0].Name
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate").Child("trialParameters").Index(1).Child("name"), "", ""),
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Duplicate name in Trial parameters",
},
// Duplicate Reference in trialParameters
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[1].Reference = i.Spec.TrialTemplate.TrialParameters[0].Reference
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate").Child("trialParameters").Index(1).Child("reference"), "", ""),
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Duplicate reference in Trial parameters",
},
// Trial template contains Trial parameters which weren't referenced from spec.parameters
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[1].Reference = "wrong-ref"
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate").Child("trialParameters").Index(1).Child("reference"), "", ""),
},
testDescription: "Trial template contains Trial parameters which weren't referenced from spec.parameters",
},
// Trial template contains Trial parameters when spec.parameters is empty
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.Parameters = nil
i.Spec.TrialTemplate.TrialParameters[1].Reference = "wrong-ref"
return i
}(),
testDescription: "Trial template contains Trial parameters when spec.parameters is empty",
},
// Trial template contains Trial metadata parameter substitution
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[1].Reference = "${trialSpec.Name}"
return i
}(),
testDescription: "Trial template contains Trial metadata reference as parameter",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[1].Reference = "${trialSpec.Annotations[test-annotation]}"
return i
}(),
testDescription: "Trial template contains Trial annotation reference as parameter",
},
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialParameters[1].Reference = "${trialSpec.Labels[test-label]}"
return i
}(),
testDescription: "Trial template contains Trial's label reference as parameter",
},
// Trial Template doesn't contain parameter from trialParameters
// missedParameterTemplate case
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Trial template doesn't contain parameter from Trial parameters",
},
// Trial Template contains extra parameter
// oddParameterTemplate case
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Trial template contains extra parameter",
},
// Trial Template parameter is invalid after substitution
// Unable convert string to unstructured
// invalidParameterTemplate case
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate").Child("trialParameters").Index(1).Child("name"), "", ""),
},
testDescription: "Trial template is unable to convert to unstructured after substitution",
},
// Trial Template contains Name and Namespace
// notEmptyMetadataTemplate case
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.TrialSpec.SetName("trial-name")
i.Spec.TrialTemplate.TrialSpec.SetNamespace("trial-namespace")
return i
}(),
wantErr: field.ErrorList{
field.Invalid(field.NewPath("spec").Child("trialTemplate"), "", ""),
},
testDescription: "Trial template contains metadata.name or metadata.namespace",
},
// Trial Template doesn't contain APIVersion or Kind
// emptyAPIVersionTemplate case
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate"), ""),
},
testDescription: "Trial template doesn't contain APIVersion or Kind",
},
// Trial Template has custom Kind
// customJobTypeTemplate case
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
return i
}(),
testDescription: "Trial template has custom Kind",
},
// Trial Template doesn't have PrimaryContainerName
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.PrimaryContainerName = ""
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate").Child("primaryContainerName"), ""),
},
testDescription: "Trial template doesn't have PrimaryContainerName",
},
// Trial Template doesn't have SuccessCondition
{
instance: func() *experimentsv1beta1.Experiment {
i := newFakeInstance()
i.Spec.TrialTemplate.SuccessCondition = ""
return i
}(),
wantErr: field.ErrorList{
field.Required(field.NewPath("spec").Child("trialTemplate"), ""),
},
testDescription: "Trial template doesn't have SuccessCondition",
},
}
for _, tc := range tcs {
gotError := g.(*DefaultValidator).validateTrialTemplate(tc.instance)
if diff := cmp.Diff(tc.wantErr, gotError, cmpopts.IgnoreFields(field.Error{}, "Detail", "BadValue")); len(diff) != 0 {
t.Errorf("Unexpected errors (-want,+got):\n%s", diff)
}
}
}
func TestValidateTrialJob(t *testing.T) {
mockCtrl := gomock.NewController(t)
defer mockCtrl.Finish()
p := manifestmock.NewMockGenerator(mockCtrl)
g := New(p)
invalidFieldBatchJob := `apiVersion: batch/v1
kind: Job
spec:
template:
spec:
containers:
name: container-must-be-list`
invalidFieldBatchJobUnstr, err := util.ConvertStringToUnstructured(invalidFieldBatchJob)
if err != nil {
t.Errorf("ConvertStringToUnstructured failed: %v", err)
}
invalidStructureBatchJob := `apiVersion: batch/v1
kind: Job
spec:
template:
invalidSpec: not-job-format
spec:
containers:
- name: invalid-list`
invalidStructureBatchJobUnstr, err := util.ConvertStringToUnstructured(invalidStructureBatchJob)
if err != nil {
t.Errorf("ConvertStringToUnstructured failed: %v", err)
}
notDefaultResourceBatchJob := `apiVersion: batch/v1
kind: Job
spec:
template:
spec:
containers:
- resources:
limits:
nvidia.com/gpu: 1
requests:
nvidia.com/gpu: 1`
notDefaultResourceBatchUnstr, err := util.ConvertStringToUnstructured(notDefaultResourceBatchJob)
if err != nil {
t.Errorf("ConvertStringToUnstructured failed: %v", err)
}
notKubernetesBatchJob := `apiVersion: test/v1
kind: Job
spec:
template:
spec:
containers:
- name: container`
notKubernetesBatchJobUnstr, err := util.ConvertStringToUnstructured(notKubernetesBatchJob)
if err != nil {
t.Errorf("ConvertStringToUnstructured failed: %v", err)
}
tcs := []struct {
runSpec *unstructured.Unstructured
err bool
testDescription string
}{
// Invalid Field Batch Job
{
runSpec: invalidFieldBatchJobUnstr,
err: true,
testDescription: "Trial template has invalid Batch Job parameter",
},
// Invalid Structure Batch Job
// Try to patch new runSpec with old Trial template
// Patch must have only "remove" operations
// Then all parameters from trial Template were correctly merged
{
runSpec: invalidStructureBatchJobUnstr,
err: true,
testDescription: "Trial template has invalid Batch Job structure",
},
// Valid case with not default Kubernetes resource (nvidia.com/gpu: 1)
{
runSpec: notDefaultResourceBatchUnstr,
err: false,
testDescription: "Valid case with nvidia.com/gpu resource in Trial template",
},
// Not kubernetes batch job
{
runSpec: notKubernetesBatchJobUnstr,
err: false,
testDescription: "Only validate Kuernetes Job",
},
}
for _, tc := range tcs {
err := g.(*DefaultValidator).validateTrialJob(tc.runSpec)
if !tc.err && err != nil {
t.Errorf("Case: %v failed. Expected nil, got %v", tc.testDescription, err)
} else if tc.err && err == nil {
t.Errorf("Case: %v failed. Expected err, got nil", tc.testDescription)
}
}
}
func TestValidateMetricsCollector(t *testing.T) {
mockCtrl := gomock.NewController(t)
defer mockCtrl.Finish()
p := manifestmock.NewMockGenerator(mockCtrl)
g := New(p)
metricsCollectorConfigData := configv1beta1.MetricsCollectorConfig{}
metricsCollectorConfigData.Image = "metricsCollectorImage"
p.EXPECT().GetMetricsCollectorConfigData(gomock.Any()).Return(metricsCollectorConfigData, nil).AnyTimes()
tcs := []struct {
instance *experimentsv1beta1.Experiment
wantErr field.ErrorList
testDescription string
}{
// Invalid Metrics Collector Kind