diff --git a/.github/workflows/template-e2e-test/action.yaml b/.github/workflows/template-e2e-test/action.yaml index 449f6eda524..7c9598df04b 100644 --- a/.github/workflows/template-e2e-test/action.yaml +++ b/.github/workflows/template-e2e-test/action.yaml @@ -33,7 +33,7 @@ runs: steps: - name: Setup Minikube Cluster shell: bash - run: ./test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh ${{ inputs.katib-ui }} ${{ inputs.trial-images }} ${{ inputs.experiments }} ${{ inputs.tune-api }} + run: ./test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh ${{ inputs.katib-ui }} ${{ inputs.tune-api }} ${{ inputs.trial-images }} ${{ inputs.experiments }} - name: Setup Katib shell: bash diff --git a/test/e2e/v1beta1/scripts/gh-actions/build-load.sh b/test/e2e/v1beta1/scripts/gh-actions/build-load.sh index d59b8f02e64..cb0ea03cd5a 100755 --- a/test/e2e/v1beta1/scripts/gh-actions/build-load.sh +++ b/test/e2e/v1beta1/scripts/gh-actions/build-load.sh @@ -25,10 +25,10 @@ pushd . cd "$(dirname "$0")/../../../../.." trap popd EXIT -TRIAL_IMAGES=${1:-""} -EXPERIMENTS=${2:-""} -DEPLOY_KATIB_UI=${3:-false} -TUNE_API=${4:-false} +DEPLOY_KATIB_UI=${1:-false} +TUNE_API=${2:-false} +TRIAL_IMAGES=${3:-""} +EXPERIMENTS=${4:-""} REGISTRY="docker.io/kubeflowkatib" TAG="e2e-test" @@ -164,7 +164,6 @@ for name in "${TRIAL_IMAGE_ARRAY[@]}"; do done # Testing image for tune function -echo $TUNE_API if "$TUNE_API"; then echo -e "\nPulling and building testing image for tune function..." _build_containers "suggestion-hyperopt" "$CMD_PREFIX/suggestion/hyperopt/$VERSION/Dockerfile" diff --git a/test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh b/test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh index f43953c8545..b890a40d41b 100755 --- a/test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh +++ b/test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh @@ -22,9 +22,9 @@ set -o nounset cd "$(dirname "$0")" DEPLOY_KATIB_UI=${1:-false} -TRIAL_IMAGES=${2:-""} -EXPERIMENTS=${3:-""} -TUNE_API=${4:-false} +TUNE_API=${2:-false} +TRIAL_IMAGES=${3:-""} +EXPERIMENTS=${4:-""} echo "Start to setup Minikube Kubernetes Cluster" kubectl version @@ -32,5 +32,4 @@ kubectl cluster-info kubectl get nodes echo "Build and Load container images" -echo "$TUNE_API" -./build-load.sh "$TRIAL_IMAGES" "$EXPERIMENTS" "$DEPLOY_KATIB_UI" "$TUNE_API" +./build-load.sh "$DEPLOY_KATIB_UI" "$TUNE_API" "$TRIAL_IMAGES" "$EXPERIMENTS"