Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate kubeflow-katib-presubmit to GitHub Actions #1878

Closed
tenzen-y opened this issue May 30, 2022 · 4 comments · Fixed by #1882
Closed

Migrate kubeflow-katib-presubmit to GitHub Actions #1878

tenzen-y opened this issue May 30, 2022 · 4 comments · Fixed by #1882

Comments

@tenzen-y
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
As described in #1877 (comment), we need to migrate our kubeflow-katib-presubmit test to Github Actions from kubeflow test-infra since it has been removed from the prow.

/cc @kubeflow/wg-automl-leads

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@tenzen-y
Copy link
Member Author

tenzen-y commented May 31, 2022

@johnugeorge
I have investigated whether all trials are executable in GHA.

experiments: https://github.com/tenzen-y/katib-actions-poc/tree/main/experiments
Actions logs: https://github.com/tenzen-y/katib-actions-poc/actions/runs/2412948245

@johnugeorge
Copy link
Member

This is great @tenzen-y

Thank you on behalf of the community for putting this hard work in short amount of time! we have validated that it will work in GHA.

I think, we are ready to convert argo workflow into GHA including other validations and docker image builds. we will try to use as much as possible from scripts like setup-katib.sh, run-e2e-experiment.sh to reuse validations. Depending on the resources available for steps, we will try to parallelise as much as possible.

Can you create a PR?

@johnugeorge
Copy link
Member

Related: kserve/kserve#2206

@tenzen-y
Copy link
Member Author

This is great @tenzen-y

Thank you on behalf of the community for putting this hard work in short amount of time! we have validated that it will work in GHA.

I think, we are ready to convert argo workflow into GHA including other validations and docker image builds. we will try to use as much as possible from scripts like setup-katib.sh, run-e2e-experiment.sh to reuse validations. Depending on the resources available for steps, we will try to parallelise as much as possible.

Can you create a PR?

Sure, @johnugeorge.
I will get right on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants