Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list_trials function do not respect experiment name filter #1919

Closed
ekesken opened this issue Jul 26, 2022 · 3 comments · Fixed by #1920
Closed

list_trials function do not respect experiment name filter #1919

ekesken opened this issue Jul 26, 2022 · 3 comments · Fixed by #1920
Assignees
Labels

Comments

@ekesken
Copy link

ekesken commented Jul 26, 2022

/kind bug

What steps did you take and what happened:

KatibClient.list_trials function is broken, it no more respects to the experiment name parameter, it returns all the existing trials for all the experiments. As you'll see name parameter is only used in the Exception message now.

What did you expect to happen:

I expect it to return the filtered trails of the experiment whose name is passed as a parameter.

Anything else you would like to add:
It's broken in this PR.

Environment:

  • Katib version (check the Katib controller image version): v0.13.0
  • Kubernetes version: (kubectl version): v1.20.15
  • OS (uname -a): Linux ... 5.4.188-104.359.amzn2.x86_64 #1 SMP Thu Apr 14 20:53:13 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Impacted by this bug? Give it a 👍 We prioritize the issues with the most 👍

@johnugeorge
Copy link
Member

Thanks for reporting this.

/cc @anencore94

@anencore94
Copy link
Member

Thanks for checking 👍 I'll check and fix this soon. @ekesken @johnugeorge

@anencore94
Copy link
Member

/assign @anencore94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants