We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google.golang.org/protobuf/testing/protocmp
We will remove a package dependency protocmp from google.golang.org/protobuf/testing/protocmp in unit test files.
protocmp
From Slack:
@Shao Wang Do you think, you have time to remove protocmp from this unit test as well so we can completely remove this dependancy from Katib: https://github.com/kubeflow/katib/blob/d2b0c4852bce239c4655e01520540aaee9e221ad/pk[…]tor/v1beta1/file-metricscollector/file-metricscollector_test.go ?
Give it a 👍 We prioritize the features with most 👍
The text was updated successfully, but these errors were encountered:
I will remove it in the following PR.
/assign
Sorry, something went wrong.
Electronic-Waste
Successfully merging a pull request may close this issue.
What you would like to be added?
We will remove a package dependency
protocmp
fromgoogle.golang.org/protobuf/testing/protocmp
in unit test files.Why is this needed?
From Slack:
Love this feature?
Give it a 👍 We prioritize the features with most 👍
The text was updated successfully, but these errors were encountered: