Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort experiments by descending creation date by default in katib-ui #2498

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sort experiments by descending creation date by default in katib-ui #2498

wants to merge 3 commits into from

Conversation

Doris-xm
Copy link
Contributor

What this PR does / why we need it:
Showing experiments from newest to oldest by default instead of sorting them by name.
Now the experiments are initially shown as follows:
2025-01-21 17 02 21

Which issue(s) this PR fixes :
Fixes #2475

Checklist:

  • Docs included if any changes are user facing

@Doris-xm
Copy link
Contributor Author

Doris-xm commented Jan 21, 2025 •
edited
Loading

It seems that an existing CI test checks if the experiment names are rendered in a alphabetical order:

katib/pkg/ui/v1beta1/frontend/cypress/e2e/index-page.cy.ts

Lines 30 to 42 in 93bee4d

it('renders every Experiment name into the table', function () {
cy.visit('/');
cy.wait(['@mockNamespacesRequest', '@mockExperimentsRequest']);
let i = 0;
const experiments = this.experimentsRequest;
// Table is sorted by Name in ascending order by default
// and experiment objects are also sorted alphabetically by name
cy.get(`[data-cy-resource-table-row="Name"]`).each(element => {
expect(element).to.contain(experiments[i].name);
i++;
});
});

which conflicts with this pr. I'm wondering if we need to change the test.

@Electronic-Waste
Copy link
Member

@Doris-xm Yeah, I think we need to change the test.

@Electronic-Waste Electronic-Waste mentioned this pull request Jan 21, 2025
Open
7 tasks
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Jan 21, 2025
@Doris-xm Doris-xm force-pushed the sort-experiment-by-time branch from 5fef940 to da3fe60 Compare January 21, 2025 12:03
@Doris-xm
Copy link
Contributor Author

/rerun-all

1 similar comment
@Doris-xm
Copy link
Contributor Author

/rerun-all

Electronic-Waste
Electronic-Waste approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this @Doris-xm. I'll leave it for other maintainers.

/lgtm
/assign @kubeflow/wg-automl-leads @helenxie-bit

@google-oss-prow google-oss-prow bot added the lgtm label Jan 21, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Electronic-Waste
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electronic-Waste Electronic-Waste Electronic-Waste approved these changes

@anencore94 anencore94 Awaiting requested review from anencore94

Assignees

@Electronic-Waste Electronic-Waste

Labels
lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort experiments by descending creation date by default
2 participants
@Doris-xm @Electronic-Waste