You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think, we should check that Metrics from the Trial were collected and saved in DB before mark Trial as succeeded.
Metrics collector is the part of the Trial.
What do you think @johnugeorge@richardsliu@gaocegege@hougangliu ?
The text was updated successfully, but these errors were encountered:
Yeah, I think we should have a condition in Trial for metrics collector, for example, metrics-collected. We should check the condition before we set the trial succeeded.
Here https://github.com/kubeflow/katib/blob/master/pkg/controller/v1alpha2/trial/trial_controller_util.go#L49 we mark Trial succeeded right after corresponding Trial job finished.
After that, we run GetSuggestion and inside Suggestion we, probably, have empty results, if Metrics Collector didn't collect logs.
I think, we should check that Metrics from the Trial were collected and saved in DB before mark Trial as succeeded.
Metrics collector is the part of the Trial.
What do you think @johnugeorge @richardsliu @gaocegege @hougangliu ?
The text was updated successfully, but these errors were encountered: