Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Metrics Collector before mark Trial succeeded #615

Closed
andreyvelich opened this issue May 31, 2019 · 2 comments · Fixed by #616
Closed

Check Metrics Collector before mark Trial succeeded #615

andreyvelich opened this issue May 31, 2019 · 2 comments · Fixed by #616

Comments

@andreyvelich
Copy link
Member

Here https://github.com/kubeflow/katib/blob/master/pkg/controller/v1alpha2/trial/trial_controller_util.go#L49 we mark Trial succeeded right after corresponding Trial job finished.
After that, we run GetSuggestion and inside Suggestion we, probably, have empty results, if Metrics Collector didn't collect logs.

I think, we should check that Metrics from the Trial were collected and saved in DB before mark Trial as succeeded.
Metrics collector is the part of the Trial.
What do you think @johnugeorge @richardsliu @gaocegege @hougangliu ?

@gaocegege
Copy link
Member

Yeah, I think we should have a condition in Trial for metrics collector, for example, metrics-collected. We should check the condition before we set the trial succeeded.

@johnugeorge
Copy link
Member

trial.status.Observation field check should be good enough to verify if metric collection is completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants