Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image for chart version 1.1.13 #1399

Closed
zzvara opened this issue Nov 19, 2021 · 6 comments
Closed

Image for chart version 1.1.13 #1399

zzvara opened this issue Nov 19, 2021 · 6 comments

Comments

@zzvara
Copy link
Contributor

zzvara commented Nov 19, 2021

The latest image tag does not support -webook-timeout flag introduced in chart version 1.1.12. Is the updated image available in some other place?

@echang0929
Copy link

Actually, you can build the image by yourself with the latest codes.

docker build -t echang0929/spark-operator:v1beta2-1.2.3-3.1.1 .
docker push echang0929/spark-operator:v1beta2-1.2.3-3.1.1

You can try the one which I created and pushed temporarily:

helm install opr-spark charts/spark-operator-chart --namespace spark-operator \
  --set sparkJobNamespace=spark-job --set webhook.enable=true \
  --set image.repository=echang0929/spark-operator --set image.tag=v1beta2-1.2.3-3.1.1

And validate it:

cat examples/spark-pi.yaml | \
  sed 's/namespace: .*/namespace: spark-job/' | \
  sed 's/serviceAccount: .*/serviceAccount: opr-spark-spark/' | \
  kubectl apply -f -

@zzvara
Copy link
Contributor Author

zzvara commented Nov 21, 2021

@echang0929 thanks, this was very useful!

Before I build the latest image, may I ask, what is the rationale behind not having the master branch on CD and automatic versioning, and why master has not been released so far? Is it because it is unstable or test coverage is not sufficient as of this writing?

I think at least a table should then be added to the Helm chart's README to tell users that the latest chart version depends on an image that is not yet released publicly.

@echang0929
Copy link

Hi @zzvara, very glad those codes can help you. As far as I understand it, your suggestion is very meaningful. I think @liyinan926 can answer your questions since he is the creator and committer of this great tool.

I notice the file .gitlab-ci.yaml. I think new docker images can be released and published automatically based on its configuration, however, probably committers need to trigger it manually, or is there any env to support it? It should be helpful if any comments about this ci file and processes can be added to the developer's document.

@TomHellier
Copy link
Contributor

I've just seen my pr was merged, so the image should exist at ghcr.io/googlecloudplatform/spark-operator:v1beta2-1.3.2-3.1.1

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants