From ef67ca8bd98aa2218e465fdc06f3a378013c2ad3 Mon Sep 17 00:00:00 2001
From: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Date: Tue, 21 Jan 2025 00:42:08 +0000
Subject: [PATCH] Fix RBAC

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
---
 manifests/v2/base/rbac/role.yaml                          | 8 --------
 .../v2/base/runtimes/pre-training/mpi-distributed.yaml    | 4 ++--
 pkg/runtime.v2/framework/plugins/mpi/mpi.go               | 4 ++--
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/manifests/v2/base/rbac/role.yaml b/manifests/v2/base/rbac/role.yaml
index 4e55b4412a..da60c6d464 100644
--- a/manifests/v2/base/rbac/role.yaml
+++ b/manifests/v2/base/rbac/role.yaml
@@ -8,14 +8,6 @@ rules:
   - ""
   resources:
   - configmaps
-  verbs:
-  - create
-  - get
-  - list
-  - watch
-- apiGroups:
-  - ""
-  resources:
   - secrets
   verbs:
   - create
diff --git a/manifests/v2/base/runtimes/pre-training/mpi-distributed.yaml b/manifests/v2/base/runtimes/pre-training/mpi-distributed.yaml
index 0c0b0c565e..324db282c4 100644
--- a/manifests/v2/base/runtimes/pre-training/mpi-distributed.yaml
+++ b/manifests/v2/base/runtimes/pre-training/mpi-distributed.yaml
@@ -1,4 +1,4 @@
-# TODO (andreyvelich): Change this to DeepSpeed or MLX runtimes
+# TODO (andreyvelich): Change this to DeepSpeed or MLX runtime.
 apiVersion: kubeflow.org/v2alpha1
 kind: ClusterTrainingRuntime
 metadata:
@@ -23,7 +23,7 @@ spec:
             spec:
               template:
                 spec:
-                  # TODO (andreyvelich): Change the command.
+                  # TODO (andreyvelich): Change the command with mpirun.
                   containers:
                     - name: launcher
                       image: busybox
diff --git a/pkg/runtime.v2/framework/plugins/mpi/mpi.go b/pkg/runtime.v2/framework/plugins/mpi/mpi.go
index 8da4061cd3..a9c335237e 100644
--- a/pkg/runtime.v2/framework/plugins/mpi/mpi.go
+++ b/pkg/runtime.v2/framework/plugins/mpi/mpi.go
@@ -61,8 +61,8 @@ var _ framework.ComponentBuilderPlugin = (*MPI)(nil)
 
 const Name = "MPI"
 
-// +kubebuilder:rbac:groups="",resources=secrets,verbs=create;get;list;watch
-// +kubebuilder:rbac:groups="",resources=configmaps,verbs=create;get;list;watch
+// +kubebuilder:rbac:groups="",resources=secrets,verbs=create;get;list;update;watch
+// +kubebuilder:rbac:groups="",resources=configmaps,verbs=create;get;list;update;watch
 
 func New(_ context.Context, client client.Client, _ client.FieldIndexer) (framework.Plugin, error) {
 	return &MPI{