Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Gloo repository in JAX Dockerfile to a specific commit #2329

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Pin Gloo repository in JAX Dockerfile to a specific commit #2329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/jax/cpu-demo/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ RUN apt-get update && apt-get install -y \

RUN git clone https://github.com/facebookincubator/gloo.git \
&& cd gloo \
&& git checkout 43b7acbf372cdce14075f3526e39153b7e433b53 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sandipanpanda!
Should we also install the specific version of jax above ?

RUN pip install jax absl-py kubernetes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can, I was wondering what do you think about keeping it this way to automatically check if Training Operator works with the latest version of JAX from time to time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that is fine for me.
Let's see if the latest version of Jax will work with this version of gloo: 43b7acbf372cdce14075f3526e39153b7e433b53

&& mkdir build \
&& cd build \
&& cmake ../ \
Expand Down
Loading