Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework no longer supported #743

Closed
KnicKnic opened this issue Nov 10, 2021 · 8 comments · Fixed by #808
Closed

Framework no longer supported #743

KnicKnic opened this issue Nov 10, 2021 · 8 comments · Fixed by #808

Comments

@KnicKnic
Copy link

In PR #603 the code was switched from emitting .netstandard 2.0 to .netstandard 2.1 . Can we change this back to .netstandard 2.0 Otherwise cannot use this package with .net Framework.
@tg123

@tg123
Copy link
Member

tg123 commented Nov 10, 2021

lol going to drop netstandard2.1 as well for crypot and json api support
May I know why do you'd like netstandard2?
it is very easy to upgrade to net5/6

@brendandburns
Copy link
Contributor

Since dotnet 2.1 is EOL'd in favor of 3.1 or 5/6 I don't think we really can or should support them, users should upgrade.

I'm not sure that the work needed to support a deprecated platform is worth it for this project given the limited resources that we currently have.

@KnicKnic
Copy link
Author

KnicKnic commented Nov 10, 2021

@brendandburns please see table https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support notice .netstandard vs .net vs .net core vs .netframework.

  • .netstandard is the compatibility layer
  • .net (can be thought of as .netcore's new name, this is a gross simplification)

.Net CORE 2.1 is EOL this is not .net standard

@tg123
Copy link
Member

tg123 commented Nov 10, 2021

netcoreapp3.0 which impl the one netstandard2.1 is also eol
https://devblogs.microsoft.com/dotnet/the-future-of-net-standard/
net5+ is new netstandard

However, I agree to provide support to netframework4.8 since it is still in support. (could be via netstandard2.0)
One solution to this might be splitting the nuget to multiple parts, making websocket related to a separated nuget.
this is also being discussed here #665 (comment)

@brendandburns
Copy link
Contributor

@KnicKnic thanks for the explanation (all of the .NET versioning stuff is pretty opaque to me)

I can see the value in supporting .NET framework 4.8 to handle legacy apps. However, I'm not certain that we have the resources to do it. We would be open to proposals as to how to best accomplish this support and also to support the work to actually implement the proposal once we design it.

Perhaps the best approach would be to send a PR with a Markdown design document and we can comment/iterate on that until we are happy with the approach?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2022
@tg123
Copy link
Member

tg123 commented Mar 24, 2022

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 24, 2022
@tg123 tg123 closed this as completed in #808 Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants