-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exec provider #2340
Fix exec provider #2340
Conversation
Welcome @tomasaschan! |
/assign |
#2303 is from @brendandburns , @@brendandburns could you please take a look at this PR? |
@brendandburns please take a look at this PR when you get a chance. |
/assign @brendandburns |
/assign @roycaihw |
@brendandburns could you take a look? |
@yliaog it's almost two weeks since @brendandburns was first pinged on this PR and we've heard nothing. This is a rather serious regression in a very central part of the library. Is there no way to move this forward without waiting for an undetermined amount of time for input from someone who doesn't seem to be in a rush to provide it? |
@tomasaschan could you try ping @brendandburns in slack? I hope he can take a look before merging this PR |
I don't know that I am on the same Slack as him...? |
thanks for the fix /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomasaschan, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
The
ExecProvider
has a regression, probably due to 8c60fe9, resulting in broken auth when using the exec provider in provided kubeconfig.Which issue(s) this PR fixes:
Fixes #2334
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: