Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exec provider #2340

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

tomasaschan
Copy link
Contributor

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

The ExecProvider has a regression, probably due to 8c60fe9, resulting in broken auth when using the exec provider in provided kubeconfig.

Which issue(s) this PR fixes:

Fixes #2334

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes bug that would fail authentication when using the exec-provider with a specific cluster selected

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Jan 29, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @tomasaschan!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2025
@tomasaschan
Copy link
Contributor Author

This potentially also fixes #2333, #2338 and #2339; I don't have access to the other third-party platforms available to test that out, but it seems likely that those auth errors are symptoms of the same thing.

@yliaog
Copy link
Contributor

yliaog commented Jan 29, 2025

/assign

@tomasaschan
Copy link
Contributor Author

@yliaog @fabianvf @roycaihw Anything I can do to speed this along?

@yliaog
Copy link
Contributor

yliaog commented Jan 31, 2025

#2303 is from @brendandburns , @@brendandburns could you please take a look at this PR?

@yliaog
Copy link
Contributor

yliaog commented Feb 2, 2025

@brendandburns please take a look at this PR when you get a chance.

@yliaog
Copy link
Contributor

yliaog commented Feb 2, 2025

/assign @brendandburns

@tomasaschan
Copy link
Contributor Author

/assign @roycaihw

@yliaog
Copy link
Contributor

yliaog commented Feb 12, 2025

@brendandburns could you take a look?

@tomasaschan
Copy link
Contributor Author

@yliaog it's almost two weeks since @brendandburns was first pinged on this PR and we've heard nothing. This is a rather serious regression in a very central part of the library. Is there no way to move this forward without waiting for an undetermined amount of time for input from someone who doesn't seem to be in a rush to provide it?

@yliaog
Copy link
Contributor

yliaog commented Feb 13, 2025

@tomasaschan could you try ping @brendandburns in slack? I hope he can take a look before merging this PR

@tomasaschan
Copy link
Contributor Author

I don't know that I am on the same Slack as him...?

@yliaog
Copy link
Contributor

yliaog commented Feb 14, 2025

thanks for the fix

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomasaschan, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit de280fb into kubernetes-client:master Feb 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 32.0.0 gke-gcloud-auth-plugin configuration break
5 participants