Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

informer cache sync needs a timeout #1459

Closed
mars1024 opened this issue Oct 14, 2021 · 1 comment · Fixed by #1460
Closed

informer cache sync needs a timeout #1459

mars1024 opened this issue Oct 14, 2021 · 1 comment · Fixed by #1460
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mars1024
Copy link
Contributor

What would you like to be added:
A timeout should be introduced to stop waiting informer cache sync forever, even it will never succeed.

Why is this needed:
https://github.com/kubernetes-sigs/kubefed/blob/5b1f868c77383ada5c19e0f3aff1a5d6f2075941/pkg/controller/sync/controller.go#L206-L229

Now isSynced function will prevent reconciliations, but it only returns true or false, which means we will wait forever, even it may not succeed.

cc @zqzten

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 14, 2021
@zqzten
Copy link
Contributor

zqzten commented Oct 14, 2021

/assign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants