Skip to content
This repository was archived by the owner on Apr 25, 2023. It is now read-only.

Validations for KubefedConfig API #916

Closed
font opened this issue May 21, 2019 · 1 comment · Fixed by #941
Closed

Validations for KubefedConfig API #916

font opened this issue May 21, 2019 · 1 comment · Fixed by #941
Assignees
Milestone

Comments

@font
Copy link
Contributor

font commented May 21, 2019

Field Validations for KubefedConfig:

  • scope must be a valid enum value. It should be immutable.
  • ControllerDuration
    • availableDelay is a valid int64 > 0
    • unavailableDelay is a valid int64 > 0
  • LeaderElectConfig
    • leaseDuration is a valid int64 > 0 and must be > renewDeadline
    • renewDeadline is a valid int64 > 0 and must be > retryPeriod * JitterFactor
    • retryPeriod is a valid int64 > 0
    • resourceLock should be a valid enum value
  • FeatureGatesConfig
    • name should be a valid feature name
    • configuration should be a valid enum value
  • ClusterHealthCheckConfig
    • All fields should be a valid int64 > 0
  • SyncControllerConfig
    • AdoptResources should be a valid enum value.
@font font added this to the v0.1.0 milestone May 21, 2019
@xunpan
Copy link
Contributor

xunpan commented May 21, 2019

  • LeaderElectConfig
    • leaseDuration must be greater than renewDeadline
    • renewDeadline must be greater than retryPeriod*JitterFactor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants