From d10e451f04e0849f36c90fb2731999e02a33d2a1 Mon Sep 17 00:00:00 2001 From: Vince Prignano Date: Mon, 3 Aug 2020 12:43:11 -0700 Subject: [PATCH] :warning: Remove logs from internal/controller Signed-off-by: Vince Prignano --- pkg/internal/controller/controller.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkg/internal/controller/controller.go b/pkg/internal/controller/controller.go index 39b9aa30de..058c6bd09a 100644 --- a/pkg/internal/controller/controller.go +++ b/pkg/internal/controller/controller.go @@ -239,9 +239,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool { // resource to be synced. if result, err := c.Do.Reconcile(ctx, req); err != nil { c.Queue.AddRateLimited(req) - if log.V(3).Enabled() { - log.Error(err, "Reconciler error") - } ctrlmetrics.ReconcileErrors.WithLabelValues(c.Name).Inc() ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "error").Inc() return false @@ -264,9 +261,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool { // get queued again until another change happens. c.Queue.Forget(obj) - // TODO(directxman12): What does 1 mean? Do we want level constants? Do we want levels at all? - log.V(5).Info("Successfully Reconciled") - ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "success").Inc() // Return true, don't take a break return true