You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When Dependabot upgraded the dependencies for v0.27.1 of apimachinary it introduces a set of new lint failures that are caused by the deprecated wait helper functions.
klient/internal/testutil/setup.go:98:8: SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
err = wait.Poll(5*time.Second, time.Minute*2,
^
klient/internal/testutil/setup.go:129:8: SA1019: wait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
err = wait.Poll(5*time.Second, time.Minute*2,
^
klient/wait/wait.go:102:11: SA1019: apimachinerywait.PollImmediateUntil is deprecated: This method does not return errors from context, use PollWithContextCancel. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
return apimachinerywait.PollImmediateUntil(options.Interval, conditionFunc, options.StopChan)
^
klient/wait/wait.go:104:10: SA1019: apimachinerywait.PollUntil is deprecated: This method does not return errors from context, use PollWithContextCancel. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
return apimachinerywait.PollUntil(options.Interval, conditionFunc, options.StopChan)
^
klient/wait/wait.go:108:10: SA1019: apimachinerywait.PollImmediate is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
return apimachinerywait.PollImmediate(options.Interval, options.Timeout, conditionFunc)
^
klient/wait/wait.go:110:9: SA1019: apimachinerywait.Poll is deprecated: This method does not return errors from context, use PollWithContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
return apimachinerywait.Poll(options.Interval, options.Timeout, conditionFunc)
^
make: *** [verify-golangci-lint] Error 1
This needs manual changes to be performed before merging.
The text was updated successfully, but these errors were encountered:
harshanarayana
changed the title
v0.27.1 of apimachinary package introduces new linter failures
v0.27.1 of apimachinery package introduces new linter failures
Apr 17, 2023
When Dependabot upgraded the dependencies for
v0.27.1
ofapimachinary
it introduces a set of new lint failures that are caused by the deprecated wait helper functions.This needs manual changes to be performed before merging.
The text was updated successfully, but these errors were encountered: