Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GatewayClassObservedGenerationBump feature type #1780

Closed
mlavacca opened this issue Mar 7, 2023 · 7 comments · Fixed by #1781
Closed

GatewayClassObservedGenerationBump feature type #1780

mlavacca opened this issue Mar 7, 2023 · 7 comments · Fixed by #1781
Assignees
@mlavacca
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.0.0

Comments

@mlavacca
Copy link
Member

mlavacca commented Mar 7, 2023

What happened:

GatewayClassObservedGenerationBump is marked as an additional feature, but it Is marked neither as extended conformance nor as experimental conformance:

gateway-api/conformance/utils/suite/suite.go

Lines 56 to 57 in f6d4eb7

// This option indicates GatewayClass will update the observedGeneration in it's conditions when reconciling
SupportGatewayClassObservedGenerationBump SupportedFeature = "GatewayClassObservedGenerationBump"

My guess is that it is extended conformance, is it correct? If so, we should add (extended conformance) at the end of the comment line as all the other features above and below.
@mlavacca mlavacca added the kind/bug Categorizes issue or PR as related to a bug. label Mar 7, 2023
@shaneutt
Copy link
Member

shaneutt commented Mar 7, 2023

This relates back to #1584 which initiated the change in the first place. In retrospect I believe the intention was to make this part of core conformance, as every implementation should be updating object status to indicate (for each condition) that they've seen the latest generation of the object.

@shaneutt shaneutt added this to the v0.6.2 milestone Mar 7, 2023
@shaneutt
Copy link
Member

shaneutt commented Mar 7, 2023

/help

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 7, 2023
@shaneutt shaneutt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 7, 2023
@mlavacca
Copy link
Member Author

mlavacca commented Mar 7, 2023

/assign

@shaneutt shaneutt moved this from Todo to In Progress in Gateway API: The Road to GA Mar 7, 2023
@mlavacca mlavacca mentioned this issue Mar 7, 2023
Merged
@shaneutt shaneutt modified the milestones: v0.6.2, v0.7.0 Mar 7, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 8, 2023

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 8, 2023
@shaneutt shaneutt modified the milestones: v0.7.0, v1.0.0 Mar 14, 2023
@shaneutt shaneutt added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. blocked labels Mar 14, 2023
@shaneutt
Copy link
Member

Blocked on #1822

@shaneutt shaneutt modified the milestones: v1.0.0, v0.8.0 Apr 6, 2023
@shaneutt
Copy link
Member

Just a status update that we're still blocked on #1822, once that is complete we should probably add this to the agenda for a few meetings in a row to give people a heads up of our intention to make it core and then go for it at some point prior to GA.

@robscott robscott removed this from the v0.8.0 milestone Jun 26, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Jul 3, 2023
@shaneutt
Copy link
Member

#1822 has gone through, this is no longer blocked @mlavacca

@shaneutt shaneutt removed the blocked label Jul 24, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Gateway API: The Road to GA Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlavacca mlavacca

Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

GatewayClassObservedGenerationBump as a core feature mlavacca/gateway-api
5 participants
@robscott @shaneutt @k8s-ci-robot @mlavacca @Xunzhuo