Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from maps to lists of named subobjects #658

Closed
robscott opened this issue May 10, 2021 · 1 comment · Fixed by #681
Closed

Transition from maps to lists of named subobjects #658

robscott opened this issue May 10, 2021 · 1 comment · Fixed by #681
Labels
breaking-change kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@robscott
Copy link
Member

robscott commented May 10, 2021

What happened:
Maps were used several places throughout the API. Including, but likely not limited to:

This is also the case for TLS options, but I think it's likely appropriate in that case.

What you expected to happen:
Lists of named subojects should be used to match the API conventions.

@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label May 10, 2021
@robscott robscott added this to the v1alpha2 milestone May 10, 2021
@hbagdi
Copy link
Contributor

hbagdi commented May 25, 2021

@robscott I have opened up #681 to handle the header modifier filter. Do we want to go ahead with TLS or not? I don't have strong feelings either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants