From 6f8d3d73623e92e1ae17b54f3673bd2bd6166da9 Mon Sep 17 00:00:00 2001 From: fabriziopandini Date: Tue, 27 Nov 2018 21:51:17 +0100 Subject: [PATCH] make verify pass --- hack/verify-golint.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hack/verify-golint.sh b/hack/verify-golint.sh index fe4f187a61..a552283f1a 100755 --- a/hack/verify-golint.sh +++ b/hack/verify-golint.sh @@ -36,8 +36,9 @@ get_golint() { GOLINT="${GOLINT:-$(get_golint)}" # we need to do this because golint ./... matches vendor... -# we also further filter out generated k8s api code in the config package -# which unfortunately fails lint ... +# we also further filter out generated k8s api code in the config v1alpha1 package +# which unfortunately fails lint due to apimachinery conventions ... +# TODO(fabrizio pandini): makes this smarter (skip only one file) go list ./... | \ - grep -v '^sigs.k8s.io/kind/pkg/cluster/config$' | \ + grep -v '^sigs.k8s.io/kind/pkg/cluster/config/v1alpha1$' | \ xargs -L1 "${GOLINT}" -set_exit_status