Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert-manager tolerations #8356

Closed
docent-net opened this issue Dec 31, 2021 · 0 comments · Fixed by #8389
Closed

cert-manager tolerations #8356

docent-net opened this issue Dec 31, 2021 · 0 comments · Fixed by #8389
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@docent-net
Copy link

What would you like to be added:

Ability to specify tolerations for cert-manager -* deployments

Why is this needed:

I have 9 pods in cluster, 3 for control plane and 6 for workloads. I have created this whole cluster without any taints. Afterwards, I have tainted those 6 workers nodes.

Today, I had an outage of one worker node - some workloads were migrated to other nodes. cert-manager pod was running on this failing node. Unfortunately, it couldn't have been migrated, as the cert-manager deployment didn't have any tolerations defined.

From what I can see, the cert-manager deployments templates don't support any tolerations: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/ingress_controller/cert_manager/templates/cert-manager.yml.j2

It looks like an easy fix I could work on, but beforehand wanted to ask whether there's something else going on, why those tolerations are not configurable as it seems like a quite common scenario.

@docent-net docent-net added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant