Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure PodsReadyTimeout integration tests with short timeout #2285

Closed
tenzen-y opened this issue May 27, 2024 · 1 comment · Fixed by #2329
Closed

Restructure PodsReadyTimeout integration tests with short timeout #2285

tenzen-y opened this issue May 27, 2024 · 1 comment · Fixed by #2329
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@tenzen-y
Copy link
Member

What would you like to be cleaned:
As we discussed here, we should use a shorter timeout (10ms) for the test cases with a single or second reconciliation and should keep using a 1s for test cases with 3 reconciliations.

For example, deactivation test cases consume 3 API calls:

  1. [workload-controller] Set .spec.active=false in the Workload
  2. [workload-controller] Set Evicted condition
  3. [jobframework controller] Stop a Job with a Requeued condition.

Why is this needed:
It would be better to decrease the duration for performing integration tests.

@tenzen-y tenzen-y added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 27, 2024
@mbobrovskyi
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants