-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the namespaced resource "Queue" #330
Comments
An additional question is whether it's worth the effort doing this for the 0.2.0 release. It is a breaking change, so we should add it as v1alpha2. However, we should probably not support v1alpha1 at the same time. Do you think the name change would be beneficial? Can we make it a breaking change? |
It is a breaking change, but one that is allowed by k8s's deprecation policy of v1alpha1 (assuming we are following that policy). I don't think we need to base our decision on this, but focus on whether this will make the API better longer term. My feeling is that introducing the prefix
|
I like the change to local queue. Helps clarify the purpose. Switching the cluster queue to global queue is less appealing. At some point we might want to manage multi-cluster queues. We'd run into confusion problems with global and multi cluster queues. |
If we want to do it, I think we should do it in 0.2.0 |
For alpha API if it really benefits, I think we can deprecate it right now. It follows the rule documented by the Honestly, when I first read the designs, I'm also confused. I thought the queue controls the queueing and the clusterQueue acts like a resource pool for sharing. But that's why documents exist, naming is hard and people may have different understandings by their knowledges. From my point of view, Considering we only published two releases, kueue is not mature enough, we should gather more feedbacks and maybe the scope of |
Changing the name now (before 0.2) has the benefit that we wouldn't be breaking too many users if we don't maintain both APIs (v1alpha1 and v1alpha2). It sounds like just adding |
Note that the namespaced |
/assign @ahg-g |
this is done |
What would you like to be added:
Rename the namespaced resource
Queue
. Possible alternatives: LocalQueueand if we feel bold about an even bigger refactor, may be we also rename
ClusterQueue
toGlobalQueue
to have consistent naming withLocalQueue
:)Other naming alternatives?
Why is this needed:
Kueue has two types of queues, namespaced and cluster-scoped. Naming the former just Queue gives the impression that it is the main resource governing queueing, including execution order and quotas, while in reality it is the ClusterQueue that enforces those semantics.
Renaming Queue would help clarify that the namespaced resource is secondary to the cluster-scoped one.
Completion requirements:
This enhancement requires the following artifacts:
The artifacts should be linked in subsequent comments.
The text was updated successfully, but these errors were encountered: