Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] node-driver-registrar prestop hook not working #1617

Closed
jlyheden opened this issue Aug 10, 2021 · 1 comment · Fixed by #1619
Closed

[cinder-csi-plugin] node-driver-registrar prestop hook not working #1617

jlyheden opened this issue Aug 10, 2021 · 1 comment · Fixed by #1619
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jlyheden
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

When I install cinder-csi using the helm chart, the node-driver-registrar fails to invoke the prestop hook due to /bin/sh not being present in the container image.

$ kubectl get events -n cinder-namespace | grep FailedPreStopHook
17m         Warning   FailedPreStopHook   pod/openstack-cinder-csi-nodeplugin-zsr2n           Exec lifecycle hook ([/bin/sh -c rm -rf /registration/cinder.csi.openstack.org /registration/cinder.csi.openstack.org-reg.sock]) for Container "node-driver-registrar" in Pod "openstack-cinder-csi-nodeplugin-zsr2n_cinder-csi(30888613-f9e1-48fd-8aca-efe5639daa4f)" failed - error: command '/bin/sh -c rm -rf /registration/cinder.csi.openstack.org /registration/cinder.csi.openstack.org-reg.sock' exited with 126: , message: "OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: exec: \"/bin/sh\": stat /bin/sh: no such file or directory: unknown\r\n"

What you expected to happen:

No warnings when applying the helm chart

How to reproduce it:

$ helm install cinder-csi cpo/openstack-cinder-csi

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager(or other related binary) version: Helm chart version 1.4.6
  • OpenStack version: don't know
  • Others: K8s 1.20.7
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 10, 2021
@ramineni
Copy link
Contributor

@jlyheden looks like preStop is no longer required. could be removed . (kubernetes-csi/node-driver-registrar#61)
Ill update the charts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants