From 9d074ce6eca230c64487d369e5cccf6311f65ec5 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Mon, 16 Oct 2023 10:19:27 +0200 Subject: [PATCH] fix invalid log calls These were found with a modified klog that enables "go vet" to check klog call parameters: cmd/kubeadm/app/features/features.go:149:4: printf: k8s.io/klog/v2.Warningf format %t has arg v of wrong type string (govet) klog.Warningf("Setting deprecated feature gate %s=%t. It will be removed in a future release.", k, v) test/images/sample-device-plugin/sampledeviceplugin.go:147:5: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet) klog.Errorf("error: %w", err) test/images/sample-device-plugin/sampledeviceplugin.go:155:3: printf: k8s.io/klog/v2.Errorf does not support error-wrapping directive %w (govet) klog.Errorf("Failed to add watch to %q: %w", triggerPath, err) staging/src/k8s.io/code-generator/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go:207:5: printf: k8s.io/klog/v2.Fatalf does not support error-wrapping directive %w (govet) klog.Fatalf("Package %v: unsupported %s value: %q :%w", i, tagEnabledName, ptag.value, err) staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:286:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet) klog.V(4).Infof("Node %s missing in vSphere cloud provider cache, trying node informer") staging/src/k8s.io/legacy-cloud-providers/vsphere/nodemanager.go:302:3: printf: (k8s.io/klog/v2.Verbose).Infof format %s reads arg #1, but call has 0 args (govet) klog.V(4).Infof("Node %s missing in vSphere cloud provider caches, trying the API server") Kubernetes-commit: 957adfac4982bf057b00a377c40dcf4150d95b92 --- .../prerelease-lifecycle-generators/status.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go b/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go index aebfeca4..823f2a8e 100644 --- a/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go +++ b/cmd/prerelease-lifecycle-gen/prerelease-lifecycle-generators/status.go @@ -204,7 +204,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat if ptag != nil { pkgNeedsGeneration, err = strconv.ParseBool(ptag.value) if err != nil { - klog.Fatalf("Package %v: unsupported %s value: %q :%w", i, tagEnabledName, ptag.value, err) + klog.Fatalf("Package %v: unsupported %s value: %q :%v", i, tagEnabledName, ptag.value, err) } } if !pkgNeedsGeneration {