This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] Allow authentication in Ingress rules #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
force-pushed
the
nginx-ingress-authentication
branch
3 times, most recently
from
cd220a7 to
742a8a6
Compare
aledbf
force-pushed
the
nginx-ingress-authentication
branch
2 times, most recently
from
6d61ea8 to
30c91c3
Compare
|
@bprashanth please review. The code is ready. I need to add the digest module to nginx and complete the docs |
|
Can one of the admins verify this patch? |
| ``` | ||
| ingress-nginx.kubernetes.io/auth-type:[basic|digest] | ||
| ingress-nginx.kubernetes.io/auth-secret:secretName | ||
| ingress-nginx.kubernetes.io/auth-realm:"realm string" |
There was a problem hiding this comment.
Please give an example of the secret too. What is realm, basic,digest? (or is there a doc you can point at that explains them), or link to your example below.
|
Can one of the admins verify this patch? |
aledbf
force-pushed
the
nginx-ingress-authentication
branch
from
30c91c3 to
fc9fd61
Compare
aledbf
changed the title
aledbf
force-pushed
the
nginx-ingress-authentication
branch
2 times, most recently
from
62b56c1 to
c617623
Compare
|
ping, also merge conflicts |
aledbf
force-pushed
the
nginx-ingress-authentication
branch
from
c617623 to
1c4fa6a
Compare
|
@bprashanth done |
|
LGTM, merge conflict |
|
@bprashanth I'll wait for #1093 to be merged before solving the conflicts :) |
aledbf
force-pushed
the
nginx-ingress-authentication
branch
from
5d6a308 to
4cda656
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #877