This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Avoid panic when labels are nil #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
feiskyer
reviewed
Apr 1, 2017
pkg/hyper/helper.go
Outdated
| @@ -187,13 +187,18 @@ func buildLabelsWithAnnotations(labels, annotations map[string]string) map[strin | |||
| return labels | |||
| } | |||
|
|
|||
| newLables := make(map[string]string) | |||
| if labels != nil { | |||
| newLables = labels | |||
There was a problem hiding this comment.
nit: it's better to exchange the position between newLables = labels and make(map[string]string)
There was a problem hiding this comment.
Yes, will do. make(map[string]string) will take more resource than newLables = labels. So newLables = labels is better. Am I right? @feiskyer
Signed-off-by: Xianglin Gao <[email protected]>
xlgao-zju
force-pushed
the
fix-nil-labels
branch
from
6d152f2 to
907385b
Compare
|
@feiskyer Updated |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frakti will panic, when we annotation is not nil but labels are nil.
/cc @feiskyer
Signed-off-by: Xianglin Gao [email protected]