Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS annotation is not supported #216

Closed
electroma opened this issue Feb 3, 2017 · 2 comments · Fixed by #244
Closed

CORS annotation is not supported #216

electroma opened this issue Feb 3, 2017 · 2 comments · Fixed by #244

Comments

@electroma
Copy link
Contributor

Version 0.8.3 had support for CORS annotation.
In this repository the only entrance for "CORS" is in nginx.tmpl: location.EnableCORS.
So existing annotation ingress.kubernetes.io/enable-cors does nothing.

Any plans to get this functionality in new version?
@aledbf
Copy link
Member

aledbf commented Feb 3, 2017 •
edited
Loading

@electroma the functionality is present in this version. Just add the annotation ingress.kubernetes.io/enable-cors: "true" in the ingress.
Just in case we changed the way the annotations are parsed. Please check here

@electroma
Copy link
Contributor Author

@aledbf that's great! Thank you for quick reply!
I suspect that I'm not the first and not the last to ask about "missing" annotation parsers.
It would be great to have some kind of FAQ for questions like this one.

@aledbf aledbf mentioned this issue Feb 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add information about cors annotation aledbf/ingress-nginx
2 participants
@aledbf @electroma