-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nginx] Add generated request id to headers #313
Comments
@foxylion please check the custom-headers example |
@aledbf Thank you, I didn't know that. But it will still leave the issue of setting also the response header ( |
@foxylion I saw this nginx/kubernetes-ingress#117 and the idea of the snippets is more than interesting. With that you can add the missing |
@foxylion right. Let me add the snippets first and then we see what is needed for the HSTS header |
@aledbf Ok, thanks. Then this one can be closed when nginx/kubernetes-ingress#117 is somehow merged. :) |
This should be merged soon. Then you could freely add your own custom configmaps in different contexts like this:
Cheers. |
@aledbf This looks good, I'll give it a try when it is released. In the case of "request id" it would be good to have such an option in the ConfigMap so that I do not have to modify all ingress configurations. May this be an option? |
To trace a request through all your services in ingress it would be good to add a
Request-Id
to request and response headers. This will allow tracking down all subsequent requests inside the cluster caused by one request from the outside.We've already modified our
nginx.tmpl
but it would be great if this could be an (optional) default.In case a default would be okay I can create a pull request (desired changes are here). For an optional default I would need some help to get the right place for adding the option to the ConfigMap. (I've never worked with Go yet.)
The text was updated successfully, but these errors were encountered: