From b3ec7910c93ef506e5594bed249de16e33e1abdf Mon Sep 17 00:00:00 2001 From: Suraj Narwade Date: Tue, 28 Mar 2017 15:21:02 +0530 Subject: [PATCH] Added warning after PVC creation Partially resolve #376 Added warning, such that PV should be created before PVC or if dynamic provision is there, no need to create PV. --- pkg/transformer/kubernetes/kubernetes.go | 5 ++++- pkg/transformer/openshift/openshift.go | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/transformer/kubernetes/kubernetes.go b/pkg/transformer/kubernetes/kubernetes.go index ed12322b80..c41d94a7b9 100644 --- a/pkg/transformer/kubernetes/kubernetes.go +++ b/pkg/transformer/kubernetes/kubernetes.go @@ -61,6 +61,9 @@ type Kubernetes struct { // used when undeploying resources from kubernetes const TIMEOUT = 300 +//default value of Persistent Volume Claim +const PVCValue = 100 + // list of all unsupported keys for this transformer // Keys are names of variables in kobject struct. // this is map to make searching for keys easier @@ -664,7 +667,7 @@ func (k *Kubernetes) Deploy(komposeObject kobject.KomposeObject, opt kobject.Con if err != nil { return err } - log.Infof("Successfully created PersistentVolumeClaim: %s", t.Name) + log.Infof("Successfully created PersistentVolumeClaim: %s of size %sMi. PVC's will not work unless a PersistentVolume has been created.", t.Name, PVCValue) case *extensions.Ingress: _, err := client.Ingress(namespace).Create(t) if err != nil { diff --git a/pkg/transformer/openshift/openshift.go b/pkg/transformer/openshift/openshift.go index 6a41d56634..ff491ebc69 100644 --- a/pkg/transformer/openshift/openshift.go +++ b/pkg/transformer/openshift/openshift.go @@ -468,7 +468,7 @@ func (o *OpenShift) Deploy(komposeObject kobject.KomposeObject, opt kobject.Conv if err != nil { return err } - log.Infof("Successfully created PersistentVolumeClaim: %s", t.Name) + log.Infof("Successfully created PersistentVolumeClaim: %s of size 100Mi. PVC's will not work unless a PersistentVolume has been created.", t.Name) case *routeapi.Route: _, err := oclient.Routes(namespace).Create(t) if err != nil {