-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests based on current issues #205
Comments
kompose could definitely use more unit test. I only see two on HEAD. I've seen a ton of PRs be merged without unit tests. Most of the work of adding new features is proper testing to prevent regressions and help reviewers have confidence in changes. It might be a reasonable idea to start enforcing tests as part of PRs as well.
|
@ericchiang That looks like a way better command to use to add to unit tests, perhaps we add this to the current |
I created PR #261 for this ^^ |
i think we are doing good on this, so closing it. Thanks @surajnarwade for bringing this to my notice! |
That fail due to libcompose v2 support...
Add wiki page and keep track of tests.
The text was updated successfully, but these errors were encountered: