Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kompose should give warning on providing blank environment variables #545

Closed
surajnarwade opened this issue Apr 5, 2017 · 3 comments
Closed
Labels
kind/discuss lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@surajnarwade
Copy link
Contributor

surajnarwade commented Apr 5, 2017

Sometimes docker-compose files have environment variables which are not set, In that case, we should give warning to user.

inspired from https://github.com/redhat-developer/opencompose

@kadel
Copy link
Member

kadel commented Apr 6, 2017

I don't know if this makes sense for docker-compose.
environment variables has one additional feature in docker-compse.
If value is not set for in docker-compose file, than value is taken from environment that runs docker-compose command.

@cdrage
Copy link
Member

cdrage commented Jul 19, 2017

@kadel @surajnarwade If a value isn't provided, docker-compose will retrieve it from the host machine.

Should we close this issue?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2018
@cdrage cdrage closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discuss lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants