-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save the cmd used to create config #639
Comments
This is a good idea. ...
annotations:
"kompose.cmd": "kompose convert --emptyvols"
"kompose.version": "0.6.0 (45a0daw)"
"kompose.data": "{version: 0.6.0, command: 'convert', emptyvols: 'true'} "
.... |
@kadel yeah even that SGTM! |
This sounds great! Would really help in term's of troubleshooting conversions. |
I am taking this up. |
This will be the pain for functional tests, as it may be
but for travis,
|
@surajnarwade Remove the pipe |
@cdrage , what I mean is we have to write template for each and every functional test as |
@surajnarwade Yup. Since you're adding annotations by default, you'll have to change every test. It's a pain-in-the-butt to do, but it's a must. |
When we generate config it is really hard to know what command was used to generate that config. And has caused issues in past. As much as important it is to have the docker-compose file to generate the artifacts the command line flags used to generate config are also important, so we should have some way to know what flags were used to generate specific config.
So I propose saving the command given to convert along with flags in annotations of generated configs
like if I use:
This should show up in the converted annotations like
This will help us mitigate issues like #632
The text was updated successfully, but these errors were encountered: