Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: incorrect version #64

Closed
janetkuo opened this issue Jul 25, 2016 · 6 comments
Closed

Bug: incorrect version #64

janetkuo opened this issue Jul 25, 2016 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@janetkuo
Copy link
Member

Downloaded release file from https://github.com/skippbox/kompose/releases/tag/v0.0.1-beta.1

$ kompose --version 
kompose version 0.0.1-alpha (HEAD)

It should instead give me:

$ kompose --version 
kompose version 0.0.1-beta (fa0930d)

Related code https://github.com/skippbox/kompose/blob/master/version/version.go

@janetkuo
Copy link
Member Author

Also in the release note we can provide checksums and installation guide, something like this:

Installation

Linux

curl -Lo kompose https://github.com/skippbox/kompose/releases/download/v0.0.1-beta.1/kompose_linux-amd64 && chmod +x kompose && sudo mv kompose /usr/local/bin/

Checksums

Linux

$ openssl sha1 /usr/local/bin/kompose
SHA1(/usr/local/bin/kompose)= 826c247a4bdca44d2b68bef48d6649dd86813ef2

@janetkuo janetkuo added the kind/bug Categorizes issue or PR as related to a bug. label Jul 25, 2016
@ngtuna
Copy link
Contributor

ngtuna commented Aug 2, 2016

closed by bc77051

@ngtuna ngtuna closed this as completed Aug 2, 2016
@janetkuo
Copy link
Member Author

The latest release gives me

$ kompose --version 
kompose version 0.0.1-beta (HEAD)

Shouldn't HEAD be replaced with commit number (in this case, c4d62c9)?

@janetkuo janetkuo reopened this Aug 10, 2016
@ngtuna
Copy link
Contributor

ngtuna commented Aug 10, 2016

Which release are u trying ? @janetkuo From my side:

$ wget https://github.com/skippbox/kompose/releases/download/v0.0.1-beta.2/kompose_linux-amd64.tar.gz
$ tar zxvf kompose_linux-amd64.tar.gz
$ kompose_linux-amd64/kompose --version
kompose version 0.0.1-beta (HEAD)

0.0.1-beta is correct, isn't it?

@janetkuo
Copy link
Member Author

Yes it's correct, but HEAD should be a commit number, right?

@ngtuna ngtuna closed this as completed in 1b50161 Aug 11, 2016
@ngtuna
Copy link
Contributor

ngtuna commented Aug 11, 2016

Ah.. I missed it. You're totally right. I made a straight-forward commit to master 1b50161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants