Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--volumes is not validated #814

Closed
kadel opened this issue Sep 13, 2017 · 2 comments
Closed

--volumes is not validated #814

kadel opened this issue Sep 13, 2017 · 2 comments
Assignees
@surajnarwade
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
1.3.0 release

Comments

@kadel
Copy link
Member

kadel commented Sep 13, 2017

If you run kompose convert --volumes foobar PVC is created and no error is raised.

This should error out as an invalid value for --volumes. Currently, only possible values are PersistentVolumeClaim and emptyDir
@kadel kadel added the kind/bug Categorizes issue or PR as related to a bug. label Sep 13, 2017
@kadel kadel mentioned this issue Sep 13, 2017
Merged
@surajnarwade
Copy link
Contributor

This should go into validation of flags, I will look into it

@surajnarwade surajnarwade self-assigned this Sep 13, 2017
@kadel kadel mentioned this issue Sep 18, 2017
Merged
@surajnarwade surajnarwade added this to the 1.3.0 release milestone Sep 27, 2017
@surajnarwade surajnarwade self-assigned this Sep 27, 2017
@surajnarwade
Copy link
Contributor

@kadel , since #817 is merged now, we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surajnarwade surajnarwade

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
1.3.0 release
Development

No branches or pull requests
2 participants
@kadel @surajnarwade