Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how developers can do use case, design, pr #1194

Closed
chrislovecnm opened this issue Dec 18, 2016 · 12 comments
Closed

Document how developers can do use case, design, pr #1194

chrislovecnm opened this issue Dec 18, 2016 · 12 comments
Assignees
Labels
area/documentation developer experience good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@chrislovecnm
Copy link
Contributor

With folks that are first time contributors to kops we often recommend that you do:

  1. Use cases in an issue
  2. Design in a PR, and update docs to match the design
  3. PR the code with test coverage

Since we are a smaller project the full design process that K8s utilizes, I believe is complete overkill. For really large changes to the code base I would like to see everyone do a quick design.

@chrislovecnm
Copy link
Contributor Author

#906

^ a perfect example how to do what I am talking about! A little more design would be awesome. But documenting the process that was used in the above PR would be magical.

@chrislovecnm
Copy link
Contributor Author

@vendrov - this is the process that I would recommend. If you want to work on SG then I would recommend an umbrella issue pulling in all of the use cases for SG improvements. Then follow the above steps

@chrislovecnm
Copy link
Contributor Author

@thockin do we have a process for the smaller projects to do design work?

Use cases are around on-boarding new developers. How do we want them through a simple process to get them up to speed, and the other half is when we have a large PR the project has a simple design process.

The design process that core uses is awesome for core, but a tad heavy for a small project.

@chrislovecnm
Copy link
Contributor Author

@vendrov once you have your head around the design. Please create a short markdown document and submit a PR. You can submit the PR using the new folder https://github.com/kubernetes/kops/tree/master/docs/design. You can look at https://github.com/kubernetes/kubernetes/tree/master/docs/design for examples.

The https://github.com/kubernetes/kubernetes/blob/master/docs/design/admission_control.md is bigger that what we need, but a good example to start.

@chrislovecnm
Copy link
Contributor Author

chrislovecnm commented Dec 18, 2016

cc @kubernetes/sig-contributor-experience-misc do we have an example that other smaller projects are using? Do you want us to use the community repository for design docs as well?

@chrislovecnm
Copy link
Contributor Author

cc: @scottmwebber

@thockin
Copy link
Member

thockin commented Dec 27, 2016

We don't have any defined process other than the main process, afaik. I'm OK with the idea of lighter-weight process for smaller repos, but I don't want to see 20 different processes for 20 different repos.

@chrislovecnm
Copy link
Contributor Author

@thockin happy to do a POC for the org. We actually may have some assistance from @scottmwebber on the PM side of the house. So let us see if we can get something cool done, which can be shared by multiple repos.

@justinsb justinsb added this to the backlog milestone Dec 28, 2016
@krisnova
Copy link
Contributor

@chrislovecnm @ScottWebber @thockin

I added this snippet to the main README over the break https://github.com/kubernetes/kops#features-1

It's not an inclusive doc by any means, but it's a starting point. We probably ought to get it into it's own file, and add the pointer in the main README.

Regardless, the important fact I wanted to mention around this was the concept of having different types of work. We already know we have bugs and features and the workflow will inherently be different for those (with some common themes).

TLDR;

There isn't just 1 type of work flow, and we should be respectful of that.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 22, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@rifelpet rifelpet added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation developer experience good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants