-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how developers can do use case, design, pr #1194
Comments
^ a perfect example how to do what I am talking about! A little more design would be awesome. But documenting the process that was used in the above PR would be magical. |
@vendrov - this is the process that I would recommend. If you want to work on SG then I would recommend an umbrella issue pulling in all of the use cases for SG improvements. Then follow the above steps |
@thockin do we have a process for the smaller projects to do design work? Use cases are around on-boarding new developers. How do we want them through a simple process to get them up to speed, and the other half is when we have a large PR the project has a simple design process. The design process that core uses is awesome for core, but a tad heavy for a small project. |
@vendrov once you have your head around the design. Please create a short markdown document and submit a PR. You can submit the PR using the new folder https://github.com/kubernetes/kops/tree/master/docs/design. You can look at https://github.com/kubernetes/kubernetes/tree/master/docs/design for examples. The https://github.com/kubernetes/kubernetes/blob/master/docs/design/admission_control.md is bigger that what we need, but a good example to start. |
cc @kubernetes/sig-contributor-experience-misc do we have an example that other smaller projects are using? Do you want us to use the community repository for design docs as well? |
cc: @scottmwebber |
We don't have any defined process other than the main process, afaik. I'm OK with the idea of lighter-weight process for smaller repos, but I don't want to see 20 different processes for 20 different repos. |
@thockin happy to do a POC for the org. We actually may have some assistance from @scottmwebber on the PM side of the house. So let us see if we can get something cool done, which can be shared by multiple repos. |
@chrislovecnm @ScottWebber @thockin I added this snippet to the main README over the break https://github.com/kubernetes/kops#features-1 It's not an inclusive doc by any means, but it's a starting point. We probably ought to get it into it's own file, and add the pointer in the main README. Regardless, the important fact I wanted to mention around this was the concept of having different types of work. We already know we have bugs and features and the workflow will inherently be different for those (with some common themes). TLDR;There isn't just 1 type of work flow, and we should be respectful of that. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
With folks that are first time contributors to kops we often recommend that you do:
Since we are a smaller project the full design process that K8s utilizes, I believe is complete overkill. For really large changes to the code base I would like to see everyone do a quick design.
The text was updated successfully, but these errors were encountered: